Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2578] Refactor SchedulerCache.GetPod() remove bool return #837

Closed
wants to merge 2 commits into from

refactor

e4c9b02
Select commit
Loading
Failed to load commit list.
Closed

[YUNIKORN-2578] Refactor SchedulerCache.GetPod() remove bool return #837

refactor
e4c9b02
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed May 13, 2024 in 0s

66.02% (-0.05%) compared to abd7011

View this Pull Request on Codecov

66.02% (-0.05%) compared to abd7011

Details

Codecov Report

Attention: Patch coverage is 58.82353% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 66.02%. Comparing base (abd7011) to head (e4c9b02).
Report is 2 commits behind head on master.

Files Patch % Lines
pkg/cache/context.go 50.00% 5 Missing and 1 partial ⚠️
pkg/cache/external/scheduler_cache.go 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #837      +/-   ##
==========================================
- Coverage   66.06%   66.02%   -0.05%     
==========================================
  Files          69       69              
  Lines        7547     7549       +2     
==========================================
- Hits         4986     4984       -2     
- Misses       2348     2352       +4     
  Partials      213      213              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.