ZEPPELIN-5690: use jinjava 2.5.4 due to cves #4329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build affected by twitter/hadoop-lzo#148 |
jongyoul
reviewed
Mar 24, 2022
| @@ -47,6 +47,8 @@ | |||
| <name>Concurrent Maven Repo</name> | |||
| <url>https://conjars.org/repo</url> | |||
| </repository> | |||
|
|
|||
| <!-- the twitter repo is unreliable (https://github.com/twitter/hadoop-lzo/issues/148) --> | |||
There was a problem hiding this comment.
In my understanding, Scalding is no longer under development. So I think we'd better remove this module itself. WDYT?
There was a problem hiding this comment.
@jongyoul jinjava is also used in submarine module - would it be possible to treat the possible removal of the scalding module as a separate issue?
There was a problem hiding this comment.
Of course, I just would like to say you don't have to consider the scalding module carefully. :-) I'll make a new PR to remove Scalding module itself.
|
LGTM |
add comment to force rebuild
pjfanning
force-pushed
the
ZEPPELIN-5690-jinjava
branch
from
5e60303
to
2e3cc85
Compare
jongyoul
approved these changes
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
use jinjava 2.5.4 due to cves
What type of PR is it?
Bug Fix
Todos
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: