Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZEPPELIN-5690: use jinjava 2.5.4 due to cves #4329

Merged
merged 1 commit into from
Mar 28, 2022
Merged

ZEPPELIN-5690: use jinjava 2.5.4 due to cves #4329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions scalding/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,8 @@
<name>Concurrent Maven Repo</name>
<url>https://conjars.org/repo</url>
</repository>

<!-- the twitter repo is unreliable (https://github.com/twitter/hadoop-lzo/issues/148) -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my understanding, Scalding is no longer under development. So I think we'd better remove this module itself. WDYT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jongyoul jinjava is also used in submarine module - would it be possible to treat the possible removal of the scalding module as a separate issue?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course, I just would like to say you don't have to consider the scalding module carefully. :-) I'll make a new PR to remove Scalding module itself.

<repository>
<id>twitter</id>
<name>Twitter Maven Repo</name>
Expand Down
2 changes: 1 addition & 1 deletion submarine/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
<!--library versions-->
<interpreter.name>submarine</interpreter.name>
<hadoop.version>${hadoop2.7.version}</hadoop.version>
<jinjava.version>2.4.0</jinjava.version>
<jinjava.version>2.5.4</jinjava.version>
<squirrel.version>0.3.8</squirrel.version>
<guava.version>24.1.1-jre</guava.version>
<!--test library versions-->
Expand Down
2 changes: 1 addition & 1 deletion zeppelin-plugins/launcher/docker/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
<dependency>
<groupId>com.hubspot.jinjava</groupId>
<artifactId>jinjava</artifactId>
<version>2.4.12</version>
<version>2.5.4</version>
</dependency>
<dependency>
<groupId>com.spotify</groupId>
Expand Down