chore: Check whether version in PR is already released #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fnesveda
added
t-platform
fnesveda
changed the title
fnesveda
changed the title
vdusek
approved these changes
Oct 24, 2023
|
Yup, once I merge it here and see that it works, I will copy it there too. |
This was referenced Oct 25, 2023
fnesveda
added a commit
to apify/apify-shared-python
that referenced
this pull request
Oct 25, 2023
We have a recurring issue that you often forget to bump the package version number in a PR, and then when you merge it to `master`, the package publication fails because the version you're trying to publish already exists. This adds a check to CI which detects these issues early and fails the CI, so you can't merge those PRs without bumping the package version number. Same as apify/apify-sdk-python#127.
fnesveda
added a commit
to apify/apify-client-python
that referenced
this pull request
Oct 25, 2023
We have a recurring issue that you often forget to bump the package version number in a PR, and then when you merge it to `master`, the package publication fails because the version you're trying to publish already exists. This adds a check to CI which detects these issues early and fails the CI, so you can't merge those PRs without bumping the package version number. It gets skipped if the title of the PR is `docs: ...`, because such PRs don't trigger package publication when merged. Same as apify/apify-sdk-python#127.
drobnikj
added
the
validated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a recurring issue that you often forget to bump the package version number in a PR, and then when you merge it to
master, the package publication fails because the version you're trying to publish already exists.This adds a check to CI which detects these issues early and fails the CI, so you can't merge those PRs without bumping the package version number.
It gets skipped if the title of the PR is
docs: ..., because such PRs don't trigger package publication when merged.