Catch and retry video module YT IFrame API ready errs #1361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Retry setting window.onYouTubeIframeAPIReady.resolve to JQuery Deferred obj .resolve up to 3 times before finally failing Log err message to console Catch and retry only TypeErrors which should result from .resolve TypeError This is direclty in edx-platform since I couldn't figure out how to override in the theme due to the webpack bundling that is done directly into VideoBlockPreview.js via add_webpack_to_frament in video_module.py ENG-97
This comment has been minimized.
This comment has been minimized.
amirtds
approved these changes
Jul 20, 2023
bryanlandia
force-pushed
the
bugfix/ENG-97-catch-and-retry-yt-api-errs
branch
from
2411b51
to
b1b3621
Compare
|
Checking git merge conflicts against https://github.com/edx/edx-platform.git
New conflicting files with 'master' |
2 similar comments
|
Checking git merge conflicts against https://github.com/edx/edx-platform.git
New conflicting files with 'master' |
|
Checking git merge conflicts against https://github.com/edx/edx-platform.git
New conflicting files with 'master' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
Retry setting window.onYouTubeIframeAPIReady.resolve to JQuery Deferred obj .resolve
up to 3 times before finally failing
Log err message to console
Catch and retry only TypeErrors which should result from .resolve TypeError
This is direclty in edx-platform since I couldn't figure out how to
override in the theme due to the webpack bundling that is done directly
into VideoBlockPreview.js via add_webpack_to_fragment in video_module.py
Type of change
Related issues
https://appsembler.atlassian.net/browse/ENG-97
Checklists
Development
Security
Code review