Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch and retry video module YT IFrame API ready errs #1361

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Catch and retry video module YT IFrame API ready errs #1361

merged 2 commits into from
Jul 20, 2023

Commits on Jul 20, 2023

  1. Catch and retry video module YT IFrame API ready errs 

    Retry setting window.onYouTubeIframeAPIReady.resolve to JQuery Deferred obj .resolve
up to 3 times before finally failing
Log err message to console
Catch and retry only TypeErrors which should result from .resolve TypeError

This is direclty in edx-platform since I couldn't figure out how to
override in the theme due to the webpack bundling that is done directly
into VideoBlockPreview.js via add_webpack_to_frament in video_module.py

ENG-97
    @bryanlandia
    bryanlandia committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    4d0c936 View commit details
    Browse the repository at this point in the history

  2. additional console error msg for window.onYouTubeIframeAPIReady err

    @bryanlandia
    bryanlandia committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    b1b3621 View commit details
    Browse the repository at this point in the history