Update general courses ordering_fields attribute to allow ordering by start date #486
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
Update general courses ordering_fields attribute to allow ordering by start date.
I’m looking to add course sorting in the dashboard by course start date. Currently sorting is possible by course name (display_name) and pacing (self_paced). Current sorting options are done at the figures API level (figures/api/course-general/). Since start_date is already defined in the serializer, I believe start_date just needs to be added to the ordering_fields attribute.
Also, date_joined is in the ordering_fields attribute, but it's not defined in GeneralCourseDataSerializer and returns a 500 error in Postman. I believe this was mistakingly added from the User/Learner serializers (e.g.).
New to Python and Django though, so correct me if I'm wrong anywhere.
Type of change
Related issues
Checklists
Development
Security
Code review