Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update general courses ordering_fields attribute to allow ordering by start date #486

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

jfaMan
Copy link
Contributor

@jfaMan jfaMan commented Nov 14, 2023

Change description

Update general courses ordering_fields attribute to allow ordering by start date.

I’m looking to add course sorting in the dashboard by course start date. Currently sorting is possible by course name (display_name) and pacing (self_paced). Current sorting options are done at the figures API level (figures/api/course-general/). Since start_date is already defined in the serializer, I believe start_date just needs to be added to the ordering_fields attribute.

Also, date_joined is in the ordering_fields attribute, but it's not defined in GeneralCourseDataSerializer and returns a 500 error in Postman. I believe this was mistakingly added from the User/Learner serializers (e.g.).

New to Python and Django though, so correct me if I'm wrong anywhere.

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@jfaMan jfaMan requested a review from amirtds November 14, 2023 03:35
@jfaMan jfaMan self-assigned this Nov 14, 2023
@jfaMan jfaMan merged commit 30fc4ec into main Nov 17, 2023
1 of 8 checks passed
@jfaMan jfaMan deleted the ajs-general-courses-ordering-fields branch November 17, 2023 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants