Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(APP-3490): Add custom label property for VoteProposalDataListItem component #296

Merged
merged 7 commits into from
Sep 23, 2024
Merged

feat(APP-3490): Add custom label property for VoteProposalDataListItem component #296

merged 7 commits into from
Sep 23, 2024

Conversation

shan8851
Copy link
Contributor

@shan8851 shan8851 commented Sep 23, 2024 •
edited
Loading

Description

  • Add custom label for VoteProposalDataListItem component.
    • Add new xs size for core Avatar component

Task: APP-3490

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [unrealeased] title and before
    the latest version.
  • I have tested my code on the test network.

@shan8851 shan8851 changed the title feat(APP-4390): Add custom label property for VoteProposalDataListItem component feat(APP-3490): Add custom label property for VoteProposalDataListItem component Sep 23, 2024
thekidnamedkd
thekidnamedkd previously approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@thekidnamedkd thekidnamedkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the changes. Approved, but left one annoying comment. Semantics, sorry! 😬

...ProposalDataListItem/voteProposalDataListItemStructure/voteProposalDataListItemStructure.tsx Outdated Show resolved Hide resolved
thekidnamedkd
thekidnamedkd previously approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@thekidnamedkd thekidnamedkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

...DataListItem/voteProposalDataListItemStructure/voteProposalDataListItemStructure.stories.tsx Outdated Show resolved Hide resolved
@shan8851 shan8851 merged commit 2f53260 into main Sep 23, 2024
4 checks passed
@shan8851 shan8851 deleted the vote-proposal-item-custom-label branch September 23, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thekidnamedkd thekidnamedkd thekidnamedkd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shan8851 @thekidnamedkd