Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

legacy: Builder refactorization (part 1...) #2286

Merged
merged 29 commits into from
Sep 6, 2023

add comments and make some plubic methods private

bf04109
Select commit
Loading
Failed to load commit list.
Merged

legacy: Builder refactorization (part 1...) #2286

add comments and make some plubic methods private
bf04109
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 5, 2023 in 0s

63.28% (target 30.00%)

View this Pull Request on Codecov

63.28% (target 30.00%)

Details

Codecov Report

Patch coverage: 69.98% and project coverage change: +0.01% 🎉

Comparison is base (0054738) 63.26% compared to head (bf04109) 63.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2286      +/-   ##
==========================================
+ Coverage   63.26%   63.28%   +0.01%     
==========================================
  Files         219      215       -4     
  Lines       19537    19549      +12     
==========================================
+ Hits        12361    12371      +10     
- Misses       6091     6098       +7     
+ Partials     1085     1080       -5     
Files Changed Coverage Δ
...duino/builder/preprocessor/arduino_preprocessor.go 0.00% <0.00%> (ø)
legacy/builder/create_cmake_rule.go 8.30% <0.00%> (ø)
legacy/builder/types/context.go 94.04% <ø> (ø)
legacy/builder/types/types.go 100.00% <ø> (+14.28%) ⬆️
legacy/builder/phases/sizer.go 45.56% <50.00%> (ø)
legacy/builder/recipe_runner.go 72.72% <50.00%> (ø)
legacy/builder/builder_utils/utils.go 71.29% <56.00%> (-0.75%) ⬇️
arduino/builder/sketch.go 54.31% <65.38%> (+0.27%) ⬆️
commands/compile/compile.go 69.05% <69.64%> (-0.13%) ⬇️
arduino/builder/utils/utils.go 72.95% <72.95%> (ø)
... and 15 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.