Refactored example scripts and notes for future work #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samgdotson
reviewed
May 2, 2024
| minute = 60 * second | ||
| hour = 60 * minute | ||
| day = 24 * hour | ||
| year = 365.25 * day |
There was a problem hiding this comment.
I would recommend using a library such as unyt for these conversions
samgdotson
reviewed
May 2, 2024
| @@ -0,0 +1,273 @@ | |||
| import solvers | |||
| import numpy as np | |||
| from data import DataHandler | |||
There was a problem hiding this comment.
data is an extremely generic name. data could suggest a file that contains data. I would recommend data_handler or something similar.
samgdotson
added
the
Status:6-Duplicate
|
This PR should be merged with #1 since it directly addresses the comments in that PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a refactored version of PR #1. This PR contains documentation for my planned approaches for handling spatial depletion in OpenMC, as well as some proof-of-concept work using a simplified PDE approach.
These purpose of this repository is to help me keep track of my scripts in a convenient manner. This repo may be referenced if/when this work proves relevant in a future publication. I plan to use these scripts in the early portion of my PhD work as a proof-of-concept to discuss the differences between different methodologies for handling spatial resolution in depletion simulations. These scripts will likely not be developed significantly beyond their current state, as the next steps of my work will likely involve working with either OpenMC or SaltProc (depending on the accuracy of loosely coupled advection in depletion).
Note: The actual number of lines to review is around 1400, but I also have the necessary OpenMC data files included here for ease of use.