Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix results didn't have same order as futures #173

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Fix results didn't have same order as futures #173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/distilabel/utils/futures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,14 @@ def when_all_complete(futures: List[Future[T]]) -> Future[T]:
completed, and it will contain the results of the `futures`.
"""
all_done_future = Future()
results = []
results = [None] * len(futures)

def check_all_done(future: Future) -> None:
results.extend(future.result())
# This is done to preserve the order of the results with respect to the order
# of the futures.
index = futures.index(future)
results[index] = future.result()[0]

_, not_done = wait(futures, return_when="FIRST_COMPLETED")
if len(not_done) == 0:
all_done_future.set_result(results)
Expand Down