-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for dedicated and serverless inference endpoints via inference API #238
Add support for dedicated and serverless inference endpoints via inference API #238
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a quick review. Usage of InferenceClient
/InferenceEndpoint
looks good to me!
Co-authored-by: Lucain <[email protected]>
Co-authored-by: Lucain <[email protected]>
Co-authored-by: Lucain <[email protected]>
Co-authored-by: Lucain <[email protected]>
Thank you very much @philschmid for your contribution and @Wauplin for the fast review 😄. Looks good, let me take a look at the docs, it shouldn't need many updates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor remarks on code, but it looks really nice! I'll test the functionality in a bit and get back with more feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code's working on my side
9ab97c0
to
5d87436
Compare
What does this PR do?
This PR currently adds a dirty implementation of how we could support dedicated Inference Endpoints and serverless Inference Endpoints via the Inference API.
On init we try to check if the provided "endpoint_name_or_model_id" (happy to revert back to endpoint_name) is available serverless using the
list_deployed_models
method.example
Note: didn't work on docs yet.