Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ingress): use GRPC instead of HTTP2 for AWS #21029

Merged
merged 1 commit into from
Dec 3, 2024
Merged

docs(ingress): use GRPC instead of HTTP2 for AWS #21029

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/operator-manual/ingress.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,7 @@ apiVersion: v1
kind: Service
metadata:
annotations:
alb.ingress.kubernetes.io/backend-protocol-version: HTTP2 #This tells AWS to send traffic from the ALB using HTTP2. Can use GRPC as well if you want to leverage GRPC specific features
alb.ingress.kubernetes.io/backend-protocol-version: GRPC # This tells AWS to send traffic from the ALB using GRPC. Plain HTTP2 can be used, but the health checks wont be available because argo currently downgrade non-grpc calls to HTTP1
labels:
app: argogrpc
name: argogrpc
Expand Down Expand Up @@ -454,7 +454,7 @@ Once we create this service, we can configure the Ingress to conditionally route
- path: /
backend:
service:
name: argogrpc
name: argogrpc # The grpc service must be placed before the argocd-server for the listening rules to be created in the correct order
port:
number: 443
pathType: Prefix
Expand Down
Loading