Skip to content

Commit

Permalink
fix: Correct limit in WorkflowTaskResultInformer List API calls. Fixes
Browse files Browse the repository at this point in the history
…#11607 (#11722)

Signed-off-by: Yuan Tang <[email protected]>
  • Loading branch information
terrytangyuan authored Sep 7, 2023
1 parent 75bd0b8 commit 1cf39d2
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions workflow/controller/taskresult.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@ func (wfc *WorkflowController) newWorkflowTaskResultInformer() cache.SharedIndex
},
func(options *metav1.ListOptions) {
options.LabelSelector = labelSelector
// `ResourceVersion=0` does not honor the `limit` in API calls, which results in making significant List calls
// without `limit`. For details, see https://github.com/argoproj/argo-workflows/pull/11343
options.ResourceVersion = ""
},
)
informer.AddEventHandler(
Expand Down

0 comments on commit 1cf39d2

Please sign in to comment.