Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(cv_tag_v3): Long workspace name to avoid conflict #679

Merged
merged 4 commits into from
Nov 8, 2023

Conversation

sugetha24
Copy link
Contributor

Change Summary

The cv_tag_v3 module creates workspaces in CloudVision under which to make the tag changes. Sometimes these workspaces are created with the same name as previously created instances, resulting in error.
The error was observed in CVP with 700+ workspaces.
Previously the WS name used 3 random alpha numberic string(42840 combinations).
The new WS name uses 6 random alpha numberic string + current datetime

Related Issue(s)

Fixes #672

Component(s) name

arista.cvp.cv_tag_v3

Proposed changes

WS name to use 6 random alpha numberic string + current datetime

How to test

molecule converge -s cv_tag_v3

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly. (check the box if not applicable)
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@sugetha24 sugetha24 added this to the v3.8.0 milestone Oct 19, 2023
@sugetha24 sugetha24 self-assigned this Oct 19, 2023
@github-actions github-actions bot added the module_utils: cv_client cv_client implementation issue label Oct 19, 2023
Copy link
Contributor

@noredistribution noredistribution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@chetryan chetryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Tested on CVP 2022.3.1 with multiple workspaces (700+)

Copy link
Contributor

@noredistribution noredistribution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@chetryan
Copy link
Contributor

Tested again after the pylint fix and the solution still works as expected.

Copy link
Contributor

@noredistribution noredistribution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@chetryan
Copy link
Contributor

chetryan commented Nov 1, 2023

Updated the format of the datetime string and tested on cloudvision

image

@sugetha24 sugetha24 modified the milestones: v3.8.0, v3.9.0 Nov 1, 2023
Copy link
Contributor

@noredistribution noredistribution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 tested again and worked fine!

@sugetha24 sugetha24 merged commit d319577 into aristanetworks:devel Nov 8, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module_utils: cv_client cv_client implementation issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workspace name clash when creating tags
3 participants