-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(cv_tag_v3): Long workspace name to avoid conflict #679
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Tested on CVP 2022.3.1 with multiple workspaces (700+)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Tested again after the pylint fix and the solution still works as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
d000c66
to
cd51454
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 tested again and worked fine!
Change Summary
The cv_tag_v3 module creates workspaces in CloudVision under which to make the tag changes. Sometimes these workspaces are created with the same name as previously created instances, resulting in error.
The error was observed in CVP with 700+ workspaces.
Previously the WS name used 3 random alpha numberic string(42840 combinations).
The new WS name uses 6 random alpha numberic string + current datetime
Related Issue(s)
Fixes #672
Component(s) name
arista.cvp.cv_tag_v3
Proposed changes
WS name to use 6 random alpha numberic string + current datetime
How to test
molecule converge -s cv_tag_v3
Checklist
User Checklist
Repository Checklist