Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_designs): Add l3_edge.l3_interfaces support #3426

Merged
merged 6 commits into from
Dec 19, 2023
Merged

Feat(eos_designs): Add l3_edge.l3_interfaces support #3426

merged 6 commits into from
Dec 19, 2023

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Dec 14, 2023 •
edited by carlbuchmann
Loading

Change Summary

Extend l3_edge and core_interfaces to support defining simple l3 interface types.

Component(s) name

arista.avd.eos_designs

Proposed changes

Extend capabilities of core_interfaces and l3_edge data model:

l3_edge | core_interfaces:
  l3_interfaces_profiles:
    - profile: <str; required; unique>
      interface: <str>
      description: <str>
      ip: <str>
      dhcp_client_accept_default_route: <bool; default=False>
      enabled: <bool; default=True>
      speed: <str>
      peer: <str>
      peer_interface: <str>
      peer_ip: <str>
      qos_profile: <str>
      raw_eos_cli: <str>
      structured_config: <dict>
  l3_interfaces:
    - node: <str>
      profile: <str>
      interface: <str>
      description: <str>
      ip: <str>
      dhcp_client_accept_default_route: <bool; default=False>
      enabled: <bool; default=True>
      speed: <str>
      peer: <str>
      peer_interface: <str>
      peer_ip: <str>
      qos_profile: <str>
      raw_eos_cli: <str>
      structured_config: <dict>

How to test

New molecule test l3_edge_l3_interfaces

@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Dec 14, 2023
@gmuloc gmuloc mentioned this pull request Dec 14, 2023
Closed
4 tasks
ClausHolbechArista
ClausHolbechArista reviewed Dec 15, 2023
View reviewed changes
ansible_collections/arista/avd/roles/eos_designs/docs/tables/l3-edge.md Outdated Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_designs/docs/tables/l3-edge.md Outdated Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_designs/docs/tables/l3-edge.md Outdated Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_designs/docs/tables/l3-edge.md Outdated Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_designs/docs/tables/l3-edge.md Outdated Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_designs/docs/tables/l3-edge.md Outdated Show resolved Hide resolved
...ista/avd/roles/eos_designs/python_modules/core_interfaces_and_l3_edge/ethernet_interfaces.py Outdated Show resolved Hide resolved
...collections/arista/avd/roles/eos_designs/python_modules/core_interfaces_and_l3_edge/utils.py Outdated Show resolved Hide resolved
.../arista/avd/roles/eos_designs/schemas/schema_fragments/defs_l3_edge_l3_interfaces.schema.yml Outdated Show resolved Hide resolved
.../arista/avd/roles/eos_designs/schemas/schema_fragments/defs_l3_edge_l3_interfaces.schema.yml Outdated Show resolved Hide resolved
@gmuloc gmuloc marked this pull request as ready for review December 15, 2023 11:30
@gmuloc gmuloc requested review from a team as code owners December 15, 2023 11:30
@ClausHolbechArista ClausHolbechArista requested a review from a team December 15, 2023 12:48
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Dec 15, 2023
@gmuloc gmuloc mentioned this pull request Dec 15, 2023
Merged
14 tasks
@gmuloc gmuloc mentioned this pull request Dec 18, 2023
Merged
34 tasks
carlbuchmann
carlbuchmann reviewed Dec 19, 2023
View reviewed changes
...ctions/arista/avd/molecule/eos_designs_unit_tests/intended/configs/l3_edge_l3_interfaces.cfg Outdated
vrf instance MGMT
!
interface Ethernet1
description peer1 eth1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we automatically build the description with an underscore i.e peer1_eth1

carlbuchmann
carlbuchmann approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small suggestion on the auto-description

@gmuloc
Copy link
Contributor Author

gmuloc commented Dec 19, 2023

LGTM, just a small suggestion on the auto-description

fixed in latest commit! Thanks :)

@gmuloc gmuloc merged commit f9fefd4 into aristanetworks:devel Dec 19, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@carlbuchmann carlbuchmann carlbuchmann approved these changes

Assignees

@gmuloc gmuloc

Labels
EPIC - AVD AutoVPN/WAN one approval This PR has one approval and is only missing one more. rn: Feat(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gmuloc @carlbuchmann @ClausHolbechArista