Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_designs): Implement AVT policies / VRF #3446

Merged
merged 27 commits into from
Jan 16, 2024
Merged

Feat(eos_designs): Implement AVT policies / VRF #3446

merged 27 commits into from
Jan 16, 2024

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Dec 18, 2023 •
edited
Loading

Change Summary

Built on top of

So it needs to be rebased regularly once they are changing.

Requires rebase onto:

Related Issue(s)

Fixes #

Component(s) name

arista.avd.eos_designs

Proposed changes

How to test

Checklist

Questions to reviewer

  • What should be the behavior if the default VRF is not in the wan_virtual_topologies.vrfs list? Auto create or raise?
    • raising for now

User Checklist

  • Adjust model following call (preferred / alternate need to change)
  • Filter non present Path-groups on edge/transit from LB policies
  • Implement control_plane AVT
  • Implement the AVT ids under CV pathfinder policies
  • Answer and address all review questions
  • Refactor the AVT ids under CV pathfinder policies (_id)
  • enforce application-profile to be defined (ignored for now)
  • Add constraint of always having prio 1 / preferred in virtual topology
  • Configure extra vrf DEFAULT policy -WITH-CP for only VRF default in case of reuse
  • For AUTOVPN - rule-id starts at 10 even when injecting CP
  • Do not put instructured_config priority 1 for preferred / preference 1 so that it is not rendered.
  • IPsec configuration - verify Dataplan / Controlp[lane config
  • Hard code 254 for Control plane ID and limit to 1-253 for others
  • Check if default virtual topology is mandatory - if so make it using index 1. and then 2-253 for indexes in the other.
  • Implement application_traffic_reognition python module
  • Make sure that policy / profiles / lb_policies are not rendered on devices where they are not used
  • Make sure that application_profile are not rendered on devices where they are not used
  • Add possibility to drop in default virtual topology (boolean) and otherwise require at least one path-group being set.
  • CONTROL-PLANE-APPLICATION-PROFILE - fix pathfinders IPs for prefix field sets once Feat(eos_designs): Preview - Generate CV Tags and metadata for WAN #3487 is merged and this PR rebased
  • Prepare for metadata for VRFs in shared_utils (?) - not needed for now

Future work

  • Reassess default VRF policy requirements (maybe auto generate)
  • Review with AutoVPN experts to simplify the outputs
  • Update documentation around wan_virtual_topologies
    • Make a special chapter on separated inventories
  • Refactor - avoid to generate profile names / policy names in multiple places (<policy_name>-<application-profile>)

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added state: Documentation role Updated role: eos_designs issue related to eos_designs role state: conflict PR with conflict labels Dec 18, 2023
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the state: conflict PR with conflict label Dec 20, 2023
@github-actions GitHub Actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Dec 20, 2023
@gmuloc gmuloc force-pushed the wan-avt branch 4 times, most recently from 8964ce0 to cff9934 Compare December 20, 2023 23:18
@gmuloc gmuloc force-pushed the wan-avt branch 2 times, most recently from 6c78aff to 92ebea3 Compare December 21, 2023 15:20
@gmuloc gmuloc force-pushed the wan-avt branch 4 times, most recently from 5f5b57b to b3ca361 Compare January 5, 2024 09:43
@gmuloc gmuloc changed the title Feat(eos_designs): Schema for AVT policies / VRF Feat(eos_designs): Implement AVT policies / VRF Jan 5, 2024
@github-actions github-actions bot added the state: conflict PR with conflict label Jan 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 5, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role and removed state: conflict PR with conflict labels Jan 8, 2024
@github-actions github-actions bot removed the state: conflict PR with conflict label Jan 15, 2024
@github-actions GitHub Actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

ClausHolbechArista
ClausHolbechArista reviewed Jan 15, 2024
View reviewed changes
...ta/avd/roles/eos_designs/schemas/schema_fragments/application_traffic_recognition.schema.yml Outdated Show resolved Hide resolved
...ions/arista/avd/roles/eos_designs/schemas/schema_fragments/wan_virtual_topologies.schema.yml Outdated Show resolved Hide resolved
...ions/arista/avd/roles/eos_designs/schemas/schema_fragments/wan_virtual_topologies.schema.yml Outdated Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_designs/python_modules/network_services/utils.py Outdated Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_designs/python_modules/network_services/utils.py Outdated Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_designs/python_modules/network_services/utils.py Outdated Show resolved Hide resolved
@ClausHolbechArista ClausHolbechArista merged commit 182516f into aristanetworks:devel Jan 16, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshitk-arista harshitk-arista harshitk-arista approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

Assignees

@gmuloc gmuloc

Labels
EPIC - AVD AutoVPN/WAN rn: Feat(eos_designs) role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gmuloc @ClausHolbechArista @harshitk-arista @carlbuchmann