Feat(eos_cli_config_gen): Support for setting BFD timers for BGP neighbors and peer-groups #3432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
role: eos_cli_config_gen
ClausHolbechArista
requested changes
Dec 15, 2023
...llections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_bgp.schema.yml
Show resolved
Hide resolved
...llections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_bgp.schema.yml
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/router-bgp.j2
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/router-bgp.j2
Outdated
Show resolved
Hide resolved
...llections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_bgp.schema.yml
Outdated
Show resolved
Hide resolved
ClausHolbechArista
changed the title
gmuloc
reviewed
Dec 19, 2023
...llections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_bgp.schema.yml
Outdated
Show resolved
Hide resolved
...llections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_bgp.schema.yml
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/router-bgp.j2
Outdated
Show resolved
Hide resolved
|
i think you will have to run pre-commit to built the AVD schema on a clone of your branch I can see your fragment do not seem in the schema
|
ClausHolbechArista
approved these changes
Jan 5, 2024
gmuloc
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for bfd in bgp at neighbor and peer_grp level
Change Summary
Added Cli model for bfd support in bgp at neighbor and peer group level.
Related Issue(s)
Fixes #
Component(s) name
arista.avd.eos_cli_config_genProposed changes
Change involves updates in the router_bgp model for supporting bfd.
How to test
Tested using molecule.
Have updated existing molecule scenarios to accommodate this use case.
Checklist
User Checklist
Repository Checklist