Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): Support for setting BFD timers for BGP neighbors and peer-groups #3432

Merged
merged 15 commits into from
Jan 5, 2024
Merged

Feat(eos_cli_config_gen): Support for setting BFD timers for BGP neighbors and peer-groups #3432

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
6db4d52
Feat(eos_cli_config_gen): Support for bfd in bgp at neighbor and peer…
amitsagar-arsita Dec 15, 2023
685fc7b
Merge branch 'aristanetworks:devel' into BFD_model_cli_config_gen
amitsagar-arsita Dec 15, 2023
201697e
Feat(eos_cli_config_gen): Addressing comments. Setting required to tr…
amitsagar-arsita Dec 15, 2023
fd30937
Feat(eos_cli_config_gen): Pushing missed updated md files
amitsagar-arsita Dec 15, 2023
a7c97b5
Merge branch 'aristanetworks:devel' into BFD_model_cli_config_gen
amitsagar-arsita Dec 19, 2023
8f757f2
Feat(eos_cli_config_gen): Addressing comments and merge BFD timers in…
amitsagar-arsita Dec 19, 2023
d5ac22c
Feat(eos_cli_config_gen): Small correction in a description in schema
amitsagar-arsita Dec 19, 2023
02ae8e6
Merge branch 'devel' into BFD_model_cli_config_gen
gmuloc Dec 20, 2023
47b9256
Merge branch 'devel' into BFD_model_cli_config_gen
gmuloc Jan 2, 2024
3e3132c
CI: Run pre-commit for schema
gmuloc Jan 2, 2024
dffd15a
Merge branch 'devel' into BFD_model_cli_config_gen
gmuloc Jan 2, 2024
fe2d4e7
CI: Run refresh-facts for molecule
gmuloc Jan 3, 2024
3d0ec69
Revert changes to markdown table heading
ClausHolbechArista Jan 5, 2024
a8ccece
Removing unrelated changes
ClausHolbechArista Jan 5, 2024
e1d4909
Merge branch 'devel' into BFD_model_cli_config_gen
ClausHolbechArista Jan 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions ...arista/avd/molecule/eos_cli_config_gen/documentation/devices/router-bgp-base.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,17 +96,17 @@ interface Management1

#### BGP Neighbors

| Neighbor | Remote AS | VRF | Shutdown | Send-community | Maximum-routes | Allowas-in | BFD | RIB Pre-Policy Retain | Route-Reflector Client | Passive |
| -------- | --------- | --- | -------- | -------------- | -------------- | ---------- | --- | --------------------- | ---------------------- | ------- |
| 192.0.3.1 | 65432 | default | - | all | - | - | True | True | - | True |
| 192.0.3.2 | 65433 | default | - | extended | 10000 | - | False | True (All) | - | - |
| 192.0.3.3 | 65434 | default | - | standard | - | - | - | True | - | - |
| 192.0.3.4 | 65435 | default | - | large | - | - | - | False | - | - |
| 192.0.3.5 | 65436 | default | - | standard | 12000 | - | - | - | - | - |
| 192.0.3.6 | 65437 | default | - | - | - | - | - | - | False | - |
| 192.0.3.7 | 65438 | default | - | - | - | - | - | - | True | - |
| 192.0.3.8 | 65438 | default | - | - | - | - | True | - | - | - |
| 192.0.3.9 | 65438 | default | - | - | - | - | False | - | - | - |
| Neighbor | Remote AS | VRF | Shutdown | Send-community | Maximum-routes | Allowas-in | BFD | BFD Intervals | RIB Pre-Policy Retain | Route-Reflector Client | Passive |
| -------- | --------- | --- | -------- | -------------- | -------------- | ---------- | --- | ------------- | --------------------- | ---------------------- | ------- |
| 192.0.3.1 | 65432 | default | - | all | - | - | True | interval: 2000, min_rx: 2000, multiplier: 3 | True | - | True |
| 192.0.3.2 | 65433 | default | - | extended | 10000 | - | False | - | True (All) | - | - |
| 192.0.3.3 | 65434 | default | - | standard | - | - | - | - | True | - | - |
| 192.0.3.4 | 65435 | default | - | large | - | - | - | - | False | - | - |
| 192.0.3.5 | 65436 | default | - | standard | 12000 | - | - | - | - | - | - |
| 192.0.3.6 | 65437 | default | - | - | - | - | - | - | - | False | - |
| 192.0.3.7 | 65438 | default | - | - | - | - | - | - | - | True | - |
| 192.0.3.8 | 65438 | default | - | - | - | - | True | - | - | - | - |
| 192.0.3.9 | 65438 | default | - | - | - | - | False | - | - | - | - |

#### BGP Neighbor Interfaces

Expand Down Expand Up @@ -165,6 +165,7 @@ router bgp 65101
neighbor 192.0.3.1 as-path remote-as replace out
neighbor 192.0.3.1 as-path prepend-own disabled
neighbor 192.0.3.1 bfd
neighbor 192.0.3.1 bfd interval 2000 min-rx 2000 multiplier 3
neighbor 192.0.3.1 rib-in pre-policy retain
neighbor 192.0.3.1 passive
neighbor 192.0.3.1 session tracker ST1
Expand Down
16 changes: 9 additions & 7 deletions ...arista/avd/molecule/eos_cli_config_gen/documentation/devices/router-bgp-evpn.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ interface Management1
| Remote AS | 65001 |
| Source | Loopback0 |
| BFD | True |
| BFD Intervals | interval: 2000, min_rx: 2000, multiplier: 3 |
| Ebgp multihop | 3 |
| Send community | all |
| Maximum routes | 0 (no limit) |
Expand All @@ -81,13 +82,13 @@ interface Management1

#### BGP Neighbors

| Neighbor | Remote AS | VRF | Shutdown | Send-community | Maximum-routes | Allowas-in | BFD | RIB Pre-Policy Retain | Route-Reflector Client | Passive |
| -------- | --------- | --- | -------- | -------------- | -------------- | ---------- | --- | --------------------- | ---------------------- | ------- |
| 192.168.255.1 | Inherited from peer group EVPN-OVERLAY-PEERS | default | - | Inherited from peer group EVPN-OVERLAY-PEERS | Inherited from peer group EVPN-OVERLAY-PEERS | Allowed, allowed 5 times | Inherited from peer group EVPN-OVERLAY-PEERS | - | - | - |
| 192.168.255.2 | Inherited from peer group EVPN-OVERLAY-PEERS | default | - | Inherited from peer group EVPN-OVERLAY-PEERS | Inherited from peer group EVPN-OVERLAY-PEERS | Inherited from peer group EVPN-OVERLAY-PEERS | Inherited from peer group EVPN-OVERLAY-PEERS | - | - | - |
| 192.168.255.3 | - | default | - | - | 52000 (warning-limit 2000, warning-only) | Allowed, allowed 5 times | - | - | - | - |
| 10.255.251.1 | Inherited from peer group MLAG-IPv4-UNDERLAY-PEER | TENANT_A_PROJECT01 | - | Inherited from peer group MLAG-IPv4-UNDERLAY-PEER | 15000 (warning-limit 50 percent) | - | - | - | - | - |
| 10.255.251.1 | Inherited from peer group MLAG-IPv4-UNDERLAY-PEER | TENANT_A_PROJECT02 | - | Inherited from peer group MLAG-IPv4-UNDERLAY-PEER | Inherited from peer group MLAG-IPv4-UNDERLAY-PEER | - | - | - | - | - |
| Neighbor | Remote AS | VRF | Shutdown | Send-community | Maximum-routes | Allowas-in | BFD | BFD Intervals | RIB Pre-Policy Retain | Route-Reflector Client | Passive |
| -------- | --------- | --- | -------- | -------------- | -------------- | ---------- | --- | ------------- | --------------------- | ---------------------- | ------- |
| 192.168.255.1 | Inherited from peer group EVPN-OVERLAY-PEERS | default | - | Inherited from peer group EVPN-OVERLAY-PEERS | Inherited from peer group EVPN-OVERLAY-PEERS | Allowed, allowed 5 times | Inherited from peer group EVPN-OVERLAY-PEERS | Inherited from peer group (interval: 2000, min_rx: 2000, multiplier: 3) | - | - | - |
| 192.168.255.2 | Inherited from peer group EVPN-OVERLAY-PEERS | default | - | Inherited from peer group EVPN-OVERLAY-PEERS | Inherited from peer group EVPN-OVERLAY-PEERS | Inherited from peer group EVPN-OVERLAY-PEERS | Inherited from peer group EVPN-OVERLAY-PEERS | Inherited from peer group (interval: 2000, min_rx: 2000, multiplier: 3) | - | - | - |
| 192.168.255.3 | - | default | - | - | 52000 (warning-limit 2000, warning-only) | Allowed, allowed 5 times | - | - | - | - | - |
| 10.255.251.1 | Inherited from peer group MLAG-IPv4-UNDERLAY-PEER | TENANT_A_PROJECT01 | - | Inherited from peer group MLAG-IPv4-UNDERLAY-PEER | 15000 (warning-limit 50 percent) | - | - | - | - | - | - |
| 10.255.251.1 | Inherited from peer group MLAG-IPv4-UNDERLAY-PEER | TENANT_A_PROJECT02 | - | Inherited from peer group MLAG-IPv4-UNDERLAY-PEER | Inherited from peer group MLAG-IPv4-UNDERLAY-PEER | - | - | - | - | - | - |

#### BGP Neighbor Interfaces

Expand Down Expand Up @@ -171,6 +172,7 @@ router bgp 65101
neighbor EVPN-OVERLAY-PEERS remote-as 65001
neighbor EVPN-OVERLAY-PEERS update-source Loopback0
neighbor EVPN-OVERLAY-PEERS bfd
neighbor EVPN-OVERLAY-PEERS bfd interval 2000 min-rx 2000 multiplier 3
neighbor EVPN-OVERLAY-PEERS allowas-in
neighbor EVPN-OVERLAY-PEERS ebgp-multihop 3
neighbor EVPN-OVERLAY-PEERS password 7 <removed>
Expand Down
31 changes: 17 additions & 14 deletions ...ta/avd/molecule/eos_cli_config_gen/documentation/devices/router-bgp-vrf-lite.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ ip route vrf BLUE-C1 193.1.2.0/24 Null0
| Address Family | ipv4 |
| Remote AS | 65000 |
| BFD | True |
| BFD Intervals | interval: 2000, min_rx: 2000, multiplier: 3 |

##### SEDI

Expand Down Expand Up @@ -126,20 +127,20 @@ ip route vrf BLUE-C1 193.1.2.0/24 Null0

#### BGP Neighbors

| Neighbor | Remote AS | VRF | Shutdown | Send-community | Maximum-routes | Allowas-in | BFD | RIB Pre-Policy Retain | Route-Reflector Client | Passive |
| -------- | --------- | --- | -------- | -------------- | -------------- | ---------- | --- | --------------------- | ---------------------- | ------- |
| 10.1.1.0 | Inherited from peer group OBS_WAN | BLUE-C1 | - | - | - | - | Inherited from peer group OBS_WAN | - | - | - |
| 10.255.1.1 | Inherited from peer group WELCOME_ROUTERS | BLUE-C1 | - | - | - | - | - | - | True | - |
| 101.0.3.1 | Inherited from peer group SEDI | BLUE-C1 | - | - | - | - | - | - | - | - |
| 101.0.3.2 | Inherited from peer group SEDI | BLUE-C1 | True | - | - | Allowed, allowed 3 (default) times | - | - | - | - |
| 101.0.3.3 | - | BLUE-C1 | Inherited from peer group SEDI-shut | - | - | Allowed, allowed 5 times | - | - | - | - |
| 101.0.3.4 | Inherited from peer group TEST-PASSIVE | BLUE-C1 | - | - | - | - | - | - | - | Inherited from peer group TEST-PASSIVE |
| 101.0.3.5 | Inherited from peer group WELCOME_ROUTERS | BLUE-C1 | - | - | - | - | False | - | - | True |
| 101.0.3.6 | Inherited from peer group WELCOME_ROUTERS | BLUE-C1 | - | - | - | - | True | - | - | - |
| 101.0.3.7 | - | BLUE-C1 | - | - | - | - | True | - | - | - |
| 101.0.3.8 | - | BLUE-C1 | - | - | - | - | False | - | - | - |
| 10.1.1.0 | Inherited from peer group OBS_WAN | RED-C1 | - | - | - | - | Inherited from peer group OBS_WAN | - | - | - |
| 10.1.1.0 | Inherited from peer group OBS_WAN | YELLOW-C1 | - | - | - | - | Inherited from peer group OBS_WAN | - | - | - |
| Neighbor | Remote AS | VRF | Shutdown | Send-community | Maximum-routes | Allowas-in | BFD | BFD Intervals | RIB Pre-Policy Retain | Route-Reflector Client | Passive |
| -------- | --------- | --- | -------- | -------------- | -------------- | ---------- | --- | ------------- | --------------------- | ---------------------- | ------- |
| 10.1.1.0 | Inherited from peer group OBS_WAN | BLUE-C1 | - | - | - | - | Inherited from peer group OBS_WAN | Inherited from peer group (interval: 2000, min_rx: 2000, multiplier: 3) | - | - | - |
| 10.255.1.1 | Inherited from peer group WELCOME_ROUTERS | BLUE-C1 | - | - | - | - | - | - | - | True | - |
| 101.0.3.1 | Inherited from peer group SEDI | BLUE-C1 | - | - | - | - | - | - | - | - | - |
| 101.0.3.2 | Inherited from peer group SEDI | BLUE-C1 | True | - | - | Allowed, allowed 3 (default) times | - | - | - | - | - |
| 101.0.3.3 | - | BLUE-C1 | Inherited from peer group SEDI-shut | - | - | Allowed, allowed 5 times | - | - | - | - | - |
| 101.0.3.4 | Inherited from peer group TEST-PASSIVE | BLUE-C1 | - | - | - | - | - | - | - | - | Inherited from peer group TEST-PASSIVE |
| 101.0.3.5 | Inherited from peer group WELCOME_ROUTERS | BLUE-C1 | - | - | - | - | False | - | - | - | True |
| 101.0.3.6 | Inherited from peer group WELCOME_ROUTERS | BLUE-C1 | - | - | - | - | True | interval: 2500, min_rx: 2000, multiplier: 3 | - | - | - |
| 101.0.3.7 | - | BLUE-C1 | - | - | - | - | True | - | - | - | - |
| 101.0.3.8 | - | BLUE-C1 | - | - | - | - | False | - | - | - | - |
| 10.1.1.0 | Inherited from peer group OBS_WAN | RED-C1 | - | - | - | - | Inherited from peer group OBS_WAN | Inherited from peer group (interval: 2000, min_rx: 2000, multiplier: 3) | - | - | - |
| 10.1.1.0 | Inherited from peer group OBS_WAN | YELLOW-C1 | - | - | - | - | Inherited from peer group OBS_WAN | Inherited from peer group (interval: 2000, min_rx: 2000, multiplier: 3) | - | - | - |

#### Router BGP VRFs

Expand All @@ -165,6 +166,7 @@ router bgp 65001
neighbor OBS_WAN as-path prepend-own disabled
neighbor OBS_WAN description BGP Connection to OBS WAN CPE
neighbor OBS_WAN bfd
neighbor OBS_WAN bfd interval 2000 min-rx 2000 multiplier 3
neighbor SEDI peer group
neighbor SEDI remote-as 65003
neighbor SEDI update-source Loopback101
Expand Down Expand Up @@ -211,6 +213,7 @@ router bgp 65001
no neighbor 101.0.3.5 bfd
neighbor 101.0.3.6 peer group WELCOME_ROUTERS
neighbor 101.0.3.6 bfd
neighbor 101.0.3.6 bfd interval 2500 min-rx 2000 multiplier 3
neighbor 101.0.3.7 bfd
aggregate-address 0.0.0.0/0 as-set summary-only attribute-map RM-BGP-AGG-APPLY-SET
aggregate-address 193.1.0.0/16 as-set summary-only attribute-map RM-BGP-AGG-APPLY-SET
Expand Down
1 change: 1 addition & 0 deletions ...e_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/router-bgp-base.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ router bgp 65101
neighbor 192.0.3.1 as-path remote-as replace out
neighbor 192.0.3.1 as-path prepend-own disabled
neighbor 192.0.3.1 bfd
neighbor 192.0.3.1 bfd interval 2000 min-rx 2000 multiplier 3
neighbor 192.0.3.1 rib-in pre-policy retain
neighbor 192.0.3.1 passive
neighbor 192.0.3.1 session tracker ST1
Expand Down
1 change: 1 addition & 0 deletions ...e_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/router-bgp-evpn.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ router bgp 65101
neighbor EVPN-OVERLAY-PEERS remote-as 65001
neighbor EVPN-OVERLAY-PEERS update-source Loopback0
neighbor EVPN-OVERLAY-PEERS bfd
neighbor EVPN-OVERLAY-PEERS bfd interval 2000 min-rx 2000 multiplier 3
neighbor EVPN-OVERLAY-PEERS allowas-in
neighbor EVPN-OVERLAY-PEERS ebgp-multihop 3
neighbor EVPN-OVERLAY-PEERS password 7 q+VNViP5i4rVjW1cxFv2wA==
Expand Down
2 changes: 2 additions & 0 deletions ...llections/arista/avd/molecule/eos_cli_config_gen/intended/configs/router-bgp-vrf-lite.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ router bgp 65001
neighbor OBS_WAN as-path prepend-own disabled
neighbor OBS_WAN description BGP Connection to OBS WAN CPE
neighbor OBS_WAN bfd
neighbor OBS_WAN bfd interval 2000 min-rx 2000 multiplier 3
neighbor SEDI peer group
neighbor SEDI remote-as 65003
neighbor SEDI update-source Loopback101
Expand Down Expand Up @@ -91,6 +92,7 @@ router bgp 65001
no neighbor 101.0.3.5 bfd
neighbor 101.0.3.6 peer group WELCOME_ROUTERS
neighbor 101.0.3.6 bfd
neighbor 101.0.3.6 bfd interval 2500 min-rx 2000 multiplier 3
neighbor 101.0.3.7 bfd
aggregate-address 0.0.0.0/0 as-set summary-only attribute-map RM-BGP-AGG-APPLY-SET
aggregate-address 193.1.0.0/16 as-set summary-only attribute-map RM-BGP-AGG-APPLY-SET
Expand Down
4 changes: 4 additions & 0 deletions ...ollections/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/router-bgp-base.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,10 @@ router_bgp:
session_tracker: ST1
# Testing bfd true OUTSIDE a peer group that should render
bfd: true
bfd_intervals:
interval: 2000
min_rx: 2000
multiplier: 3
- ip_address: 192.0.3.2
remote_as: 65433
send_community: extended
Expand Down
4 changes: 4 additions & 0 deletions ...ollections/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/router-bgp-evpn.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ router_bgp:
remote_as: 65001
update_source: Loopback0
bfd: true
bfd_intervals:
interval: 2000
min_rx: 2000
multiplier: 3
ebgp_multihop: 3
password: "q+VNViP5i4rVjW1cxFv2wA=="
send_community: all
Expand Down
8 changes: 8 additions & 0 deletions ...ctions/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/router-bgp-vrf-lite.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,10 @@ router_bgp:
remote_as_replace_out: true
prepend_own_disabled: true
bfd: true
bfd_intervals:
interval: 2000
min_rx: 2000
multiplier: 3
- name: WELCOME_ROUTERS
type: ipv4
description: 'BGP Connection to WELCOME ROUTER 02'
Expand Down Expand Up @@ -119,6 +123,10 @@ router_bgp:
- ip_address: 101.0.3.6
peer_group: WELCOME_ROUTERS
bfd: true
bfd_intervals:
interval: 2500
min_rx: 2000
multiplier: 3
# Testing bfd true OUTSIDE a peer group that should render
- ip_address: 101.0.3.7
bfd: true
Expand Down
Loading
Loading