Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(plugins): Move jinja filter code for arista.avd.generate_lacp_id to PyAVD #4139

Merged

Conversation

Shivani-gslab
Copy link
Contributor

Change Summary

Move jinja filter code for arista.avd.generate_lacp_id to PyAVD

Related Issue(s)

Fixes #

Component(s) name

Filter -

  • arista.avd.generate_lacp_id

Proposed changes

Moving the code and unit tests for arista.avd.is_in_filter filter to PyAVD

How to test

CI should catch things.

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4139
# Activate the virtual environment
source test-avd-pr-4139/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@generate_lacp_id#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,generate_lacp_id --force
# Optional: Install AVD examples
cd test-avd-pr-4139
ansible-playbook arista.avd.install_examples

@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review June 20, 2024 06:25
@Vibhu-gslab Vibhu-gslab requested review from a team as code owners June 20, 2024 06:25
@Vibhu-gslab Vibhu-gslab marked this pull request as draft June 20, 2024 06:26
@gmuloc gmuloc requested a review from a team June 20, 2024 09:36
@Shivani-gslab Shivani-gslab marked this pull request as ready for review June 20, 2024 09:38
@ClausHolbechArista ClausHolbechArista merged commit 384047b into aristanetworks:devel Jun 20, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants