-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_cli_config_gen): Add support for LSP and CSNP timers under router_isis #4619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4619
# Activate the virtual environment
source test-avd-pr-4619/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@isis_timers#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,isis_timers --force
# Optional: Install AVD examples
cd test-avd-pr-4619
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
labels
Oct 21, 2024
for more information, see https://pre-commit.ci
Shivani-gslab
force-pushed
the
isis_timers
branch
from
October 21, 2024 12:03
aa09ebd
to
7ad25d4
Compare
Shivani-gslab
force-pushed
the
isis_timers
branch
from
October 21, 2024 12:07
7ad25d4
to
f042ce7
Compare
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/router_isis.schema.yml
Outdated
Show resolved
Hide resolved
Co-authored-by: laxmikantchintakindi <[email protected]>
Shivani-gslab
force-pushed
the
isis_timers
branch
from
October 22, 2024 11:44
d65bf0c
to
834e878
Compare
Shivani-gslab
force-pushed
the
isis_timers
branch
from
October 22, 2024 11:46
834e878
to
be44eb2
Compare
laxmikantchintakindi
approved these changes
Oct 22, 2024
MaheshGSLAB
reviewed
Oct 23, 2024
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/router_isis.schema.yml
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/router-isis.cfg
Show resolved
Hide resolved
MaheshGSLAB
approved these changes
Oct 24, 2024
ClausHolbechArista
previously requested changes
Oct 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking until 5.0 is out
ClausHolbechArista
dismissed
their stale review
October 28, 2024 08:13
5.0 is out so this can be reviewed and merged
ClausHolbechArista
added
the
one approval
This PR has one approval and is only missing one more.
label
Oct 28, 2024
gmuloc
requested changes
Oct 28, 2024
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/router_isis.schema.yml
Outdated
Show resolved
Hide resolved
gmuloc
requested changes
Oct 28, 2024
ansible_collections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/router-isis.md
Show resolved
Hide resolved
Shivani-gslab
commented
Nov 4, 2024
ansible_collections/arista/avd/molecule/eos_config_deploy_cvp/documentation/devices/DC1-BL1A.md
Show resolved
Hide resolved
gmuloc
reviewed
Nov 4, 2024
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/router-isis.j2
Show resolved
Hide resolved
Shivani-gslab
force-pushed
the
isis_timers
branch
from
November 5, 2024 05:53
f7fde0d
to
bd63448
Compare
Quality Gate passedIssues Measures |
gmuloc
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
one approval
This PR has one approval and is only missing one more.
rn: Feat(eos_cli_config_gen)
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Add support for LSP and CSNP timers under router_isis
Related Issue(s)
Fixes #4287
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
How to test
Molecule test and check EOS CLI.
Checklist
User Checklist
Repository Checklist