Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Add support for LSP and CSNP timers under router_isis #4619

Merged
merged 19 commits into from
Nov 7, 2024

Conversation

Shivani-gslab
Copy link
Contributor

@Shivani-gslab Shivani-gslab commented Oct 21, 2024

Change Summary

Add support for LSP and CSNP timers under router_isis

Related Issue(s)

Fixes #4287

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

router_isis:
    timers:
        # Link State Packet timers
        lsp:
          generation:

            # Maximum interval (in seconds) between generating two LSPs.
            interval: <int; 1-300; required>

            # Initial wait time (in milliseconds) before generating LSPs.
            initial_wait_time: <int; 1-300000>

            # Wait time (in milliseconds) between generating the first and second LSPs.
            wait_time: <int; 1-300000>

          # Transmit delay (in milliseconds) for link state packets.
          out_delay: <int; 1-65000>

          # Interval (in seconds) between two LSP refreshes.
          refresh_interval: <int; 30-65535>

          # Minimum remaining lifetime for LSPs (in seconds).
          min_remaining_lifetime: <int; 60-65535>
        csnp_generation:

          # Transmit frequency (in seconds) for CSN packets.
          interval: <int; 1-300>

          # Disable periodic CSN packets.
          p2p_disabled: <bool>

How to test

Molecule test and check EOS CLI.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4619
# Activate the virtual environment
source test-avd-pr-4619/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@isis_timers#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,isis_timers --force
# Optional: Install AVD examples
cd test-avd-pr-4619
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Oct 21, 2024
@Shivani-gslab Shivani-gslab marked this pull request as ready for review October 23, 2024 05:56
@Shivani-gslab Shivani-gslab requested review from a team as code owners October 23, 2024 05:56
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking until 5.0 is out

@ClausHolbechArista ClausHolbechArista dismissed their stale review October 28, 2024 08:13

5.0 is out so this can be reviewed and merged

@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Oct 28, 2024
@Shivani-gslab Shivani-gslab marked this pull request as draft November 4, 2024 07:31
@Shivani-gslab Shivani-gslab marked this pull request as ready for review November 4, 2024 11:04
@Shivani-gslab Shivani-gslab marked this pull request as draft November 5, 2024 04:53
Copy link

sonarcloud bot commented Nov 7, 2024

@gmuloc gmuloc merged commit 8502431 into aristanetworks:devel Nov 7, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Additional support to modify ISIS timers
5 participants