Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): Add support for LSP and CSNP timers under router_isis #4619

Merged
merged 19 commits into from
Nov 7, 2024
Merged

Feat(eos_cli_config_gen): Add support for LSP and CSNP timers under router_isis #4619

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
72e2739
Feat(eos_cli_config_gen): Additional support to modify ISIS timers
Shivani-gslab Oct 21, 2024
21f142e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 21, 2024
f042ce7
Updating doc template
Shivani-gslab Oct 21, 2024
ef3ca86
Apply suggestion
Shivani-gslab Oct 22, 2024
b2a0432
Molecule output for suggested change
Shivani-gslab Oct 22, 2024
be44eb2
Apply suggestion
Shivani-gslab Oct 22, 2024
017f29f
Improve coverage and apply suggestion
Shivani-gslab Oct 24, 2024
a54c899
Merge branch 'devel' into isis_timers
gmuloc Oct 28, 2024
55a849b
Merge branch 'devel' into isis_timers
gmuloc Oct 28, 2024
b81172b
Refactor(eos_cli_config_gen): Adjust schema for consistency
gmuloc Oct 28, 2024
7710c2d
update doc template
Shivani-gslab Nov 4, 2024
eed517f
Merge branch 'devel' into isis_timers
Shivani-gslab Nov 4, 2024
8661cdf
Fix table heading
Shivani-gslab Nov 4, 2024
d5161de
molecule outout
Shivani-gslab Nov 4, 2024
f92ab40
Fix molecule output
Shivani-gslab Nov 4, 2024
cad4e2a
Merge branch 'devel' into isis_timers
Shivani-gslab Nov 4, 2024
c7a401e
Merge branch 'devel' into isis_timers
gmuloc Nov 4, 2024
bd63448
Fix table for local convergence
Shivani-gslab Nov 5, 2024
da6b77e
Merge branch 'devel' into isis_timers
gmuloc Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ...s/arista/avd/molecule/eos_cli_config_gen/documentation/devices/router-isis-2.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,12 @@ interface Management1
| -------- | ----- |
| Instance | EVPN_UNDERLAY |

#### ISIS Route Timers

| Settings | Value |
| -------- | ----- |
| LSP Generation Maximum Interval | 30 seconds |

#### ISIS Interfaces Summary

| Interface | ISIS Instance | ISIS Metric | Interface Mode |
Expand All @@ -57,6 +63,7 @@ interface Management1
router isis EVPN_UNDERLAY
set-overload-bit
set-overload-bit on-startup 55
timers lsp generation 30
authentication mode sha key-id 4 rx-disabled
!
```
10 changes: 9 additions & 1 deletion ...arista/avd/molecule/eos_cli_config_gen/documentation/devices/router-isis-new.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,6 @@ interface Vlan4094
| Instance | EVPN_UNDERLAY |
| Log Adjacency Changes | False |
| MPLS LDP Sync Default | True |
| Local Convergence Delay (ms) | 10000 |
| Advertise Passive-only | True |
| SR MPLS Enabled | True |
| SPF Interval | 250 seconds |
Expand All @@ -205,6 +204,14 @@ interface Vlan4094
| Graceful-restart t2 Level-2 | 20 |
| Graceful-restart Restart-hold-time | 10 |

#### ISIS Route Timers

| Settings | Value |
| -------- | ----- |
| Local Convergence Delay | 10000 milliseconds |
| LSP Generation Maximum Interval | 30 seconds |
| LSP Generation Initial Wait-time | 40 milliseconds |

#### ISIS Route Redistribution

| Route Type | Route-Map | Include Leaked |
Expand Down Expand Up @@ -282,6 +289,7 @@ router isis EVPN_UNDERLAY
set-overload-bit
advertise passive-only
spf-interval 250 seconds 10 milliseconds 20 milliseconds
timers lsp generation 30 40
authentication mode shared-secret profile test1 algorithm md5 level-1
authentication mode sha key-id 2 level-2
graceful-restart
Expand Down
21 changes: 20 additions & 1 deletion ...ons/arista/avd/molecule/eos_cli_config_gen/documentation/devices/router-isis.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,11 +281,24 @@ interface Vlan4094
| Type | level-2 |
| Router-ID | 192.168.255.3 |
| Log Adjacency Changes | True |
| Local Convergence Delay (ms) | 15000 |
| Advertise Passive-only | True |
| SR MPLS Enabled | False |
| SPF Interval | 250 seconds |

#### ISIS Route Timers

| Settings | Value |
| -------- | ----- |
| Local Convergence Delay | 15000 milliseconds |
| CSN Packet Transmission Interval | 10 seconds |
| CSN Packet P2P Links Disabled | True |
| LSP Generation Maximum Interval | 30 seconds |
| LSP Generation Initial Wait-time | 40 milliseconds |
| LSP Generation Wait-time | 50 milliseconds |
| LSP Out-delay | 20 milliseconds |
| LSP Refresh Interval | 56 seconds |
| LSP Minimum Remaining Lifetime | 78 seconds |
gmuloc marked this conversation as resolved.
Show resolved Hide resolved

#### ISIS Route Redistribution

| Route Type | Route-Map | Include Leaked |
Expand Down Expand Up @@ -352,6 +365,12 @@ router isis EVPN_UNDERLAY
set-overload-bit on-startup wait-for-bgp
advertise passive-only
spf-interval 250
timers csnp generation interval 10 seconds
timers csnp generation p2p disabled
timers lsp out-delay 20
timers lsp refresh 56
timers lsp generation 30 40 50
timers lsp min-remaining-lifetime 78
authentication mode sha key-id 5 rx-disabled level-1
authentication mode shared-secret profile test2 algorithm md5 rx-disabled level-2
authentication key 0 password
Expand Down
1 change: 1 addition & 0 deletions ...ble_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/router-isis-2.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ interface Management1
router isis EVPN_UNDERLAY
set-overload-bit
set-overload-bit on-startup 55
timers lsp generation 30
authentication mode sha key-id 4 rx-disabled
!
1 change: 1 addition & 0 deletions ...e_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/router-isis-new.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ router isis EVPN_UNDERLAY
set-overload-bit
advertise passive-only
spf-interval 250 seconds 10 milliseconds 20 milliseconds
timers lsp generation 30 40
authentication mode shared-secret profile test1 algorithm md5 level-1
authentication mode sha key-id 2 level-2
graceful-restart
Expand Down
6 changes: 6 additions & 0 deletions ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/router-isis.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,12 @@ router isis EVPN_UNDERLAY
set-overload-bit on-startup wait-for-bgp
advertise passive-only
spf-interval 250
timers csnp generation interval 10 seconds
MaheshGSLAB marked this conversation as resolved.
Show resolved Hide resolved
timers csnp generation p2p disabled
timers lsp out-delay 20
timers lsp refresh 56
timers lsp generation 30 40 50
timers lsp min-remaining-lifetime 78
authentication mode sha key-id 5 rx-disabled level-1
authentication mode shared-secret profile test2 algorithm md5 rx-disabled level-2
authentication key 0 password
Expand Down
4 changes: 4 additions & 0 deletions ..._collections/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/router-isis-2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ router_isis:
enabled: true
on_startup:
delay: 55
timers:
lsp:
generation:
interval: 30
authentication:
both:
key_type: 0
Expand Down
4 changes: 4 additions & 0 deletions ...ollections/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/router-isis-new.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@ router_isis:
timers:
local_convergence:
protected_prefixes: true
lsp:
generation:
interval: 30
initial_wait_time: 40
advertise:
passive_only: true
redistribute_routes:
Expand Down
12 changes: 12 additions & 0 deletions ...le_collections/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/router-isis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,18 @@ router_isis:
local_convergence:
protected_prefixes: true
delay: 15000
csnp:
generation:
interval: 10
p2p_disabled: true
lsp:
out_delay: 20
refresh_interval: 56
generation:
interval: 30
initial_wait_time: 40
wait_time: 50
min_remaining_lifetime: 78
advertise:
passive_only: true
redistribute_routes:
Expand Down
6 changes: 3 additions & 3 deletions ...ons/arista/avd/molecule/eos_config_deploy_cvp/documentation/devices/DC1-BL1A.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -690,9 +690,9 @@ ASN Notation: asplain

##### EVPN Peer Groups

| Peer Group | Activate | Encapsulation |
| ---------- | -------- | ------------- |
| EVPN-OVERLAY-PEERS | True | default |
| Peer Group | Activate | Route-map In | Route-map Out | Encapsulation |
| ---------- | -------- | ------------ | ------------- | ------------- |
| EVPN-OVERLAY-PEERS | True | - | - | default |

gmuloc marked this conversation as resolved.
Show resolved Hide resolved
#### Router BGP VLAN Aware Bundles

Expand Down
6 changes: 3 additions & 3 deletions ...ons/arista/avd/molecule/eos_config_deploy_cvp/documentation/devices/DC1-BL1B.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -690,9 +690,9 @@ ASN Notation: asplain

##### EVPN Peer Groups

| Peer Group | Activate | Encapsulation |
| ---------- | -------- | ------------- |
| EVPN-OVERLAY-PEERS | True | default |
| Peer Group | Activate | Route-map In | Route-map Out | Encapsulation |
| ---------- | -------- | ------------ | ------------- | ------------- |
| EVPN-OVERLAY-PEERS | True | - | - | default |

#### Router BGP VLAN Aware Bundles

Expand Down
6 changes: 3 additions & 3 deletions ...s/arista/avd/molecule/eos_config_deploy_cvp/documentation/devices/DC1-LEAF1A.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -566,9 +566,9 @@ ASN Notation: asplain

##### EVPN Peer Groups

| Peer Group | Activate | Encapsulation |
| ---------- | -------- | ------------- |
| EVPN-OVERLAY-PEERS | True | default |
| Peer Group | Activate | Route-map In | Route-map Out | Encapsulation |
| ---------- | -------- | ------------ | ------------- | ------------- |
| EVPN-OVERLAY-PEERS | True | - | - | default |

#### Router BGP VLAN Aware Bundles

Expand Down
6 changes: 3 additions & 3 deletions ...s/arista/avd/molecule/eos_config_deploy_cvp/documentation/devices/DC1-LEAF2A.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -920,9 +920,9 @@ ASN Notation: asplain

##### EVPN Peer Groups

| Peer Group | Activate | Encapsulation |
| ---------- | -------- | ------------- |
| EVPN-OVERLAY-PEERS | True | default |
| Peer Group | Activate | Route-map In | Route-map Out | Encapsulation |
| ---------- | -------- | ------------ | ------------- | ------------- |
| EVPN-OVERLAY-PEERS | True | - | - | default |

#### Router BGP VLAN Aware Bundles

Expand Down
6 changes: 3 additions & 3 deletions ...s/arista/avd/molecule/eos_config_deploy_cvp/documentation/devices/DC1-LEAF2B.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -920,9 +920,9 @@ ASN Notation: asplain

##### EVPN Peer Groups

| Peer Group | Activate | Encapsulation |
| ---------- | -------- | ------------- |
| EVPN-OVERLAY-PEERS | True | default |
| Peer Group | Activate | Route-map In | Route-map Out | Encapsulation |
| ---------- | -------- | ------------ | ------------- | ------------- |
| EVPN-OVERLAY-PEERS | True | - | - | default |

#### Router BGP VLAN Aware Bundles

Expand Down
6 changes: 3 additions & 3 deletions ...s/arista/avd/molecule/eos_config_deploy_cvp/documentation/devices/DC1-SPINE1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,9 +420,9 @@ ASN Notation: asplain

##### EVPN Peer Groups

| Peer Group | Activate | Encapsulation |
| ---------- | -------- | ------------- |
| EVPN-OVERLAY-PEERS | True | default |
| Peer Group | Activate | Route-map In | Route-map Out | Encapsulation |
| ---------- | -------- | ------------ | ------------- | ------------- |
| EVPN-OVERLAY-PEERS | True | - | - | default |

#### Router BGP Device Configuration

Expand Down
6 changes: 3 additions & 3 deletions ...s/arista/avd/molecule/eos_config_deploy_cvp/documentation/devices/DC1-SPINE2.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,9 +420,9 @@ ASN Notation: asplain

##### EVPN Peer Groups

| Peer Group | Activate | Encapsulation |
| ---------- | -------- | ------------- |
| EVPN-OVERLAY-PEERS | True | default |
| Peer Group | Activate | Route-map In | Route-map Out | Encapsulation |
| ---------- | -------- | ------------ | ------------- | ------------- |
| EVPN-OVERLAY-PEERS | True | - | - | default |

#### Router BGP Device Configuration

Expand Down
6 changes: 3 additions & 3 deletions ...s/arista/avd/molecule/eos_config_deploy_cvp/documentation/devices/DC1-SPINE3.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,9 +420,9 @@ ASN Notation: asplain

##### EVPN Peer Groups

| Peer Group | Activate | Encapsulation |
| ---------- | -------- | ------------- |
| EVPN-OVERLAY-PEERS | True | default |
| Peer Group | Activate | Route-map In | Route-map Out | Encapsulation |
| ---------- | -------- | ------------ | ------------- | ------------- |
| EVPN-OVERLAY-PEERS | True | - | - | default |

#### Router BGP Device Configuration

Expand Down
6 changes: 3 additions & 3 deletions ...s/arista/avd/molecule/eos_config_deploy_cvp/documentation/devices/DC1-SPINE4.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,9 +420,9 @@ ASN Notation: asplain

##### EVPN Peer Groups

| Peer Group | Activate | Encapsulation |
| ---------- | -------- | ------------- |
| EVPN-OVERLAY-PEERS | True | default |
| Peer Group | Activate | Route-map In | Route-map Out | Encapsulation |
| ---------- | -------- | ------------ | ------------- | ------------- |
| EVPN-OVERLAY-PEERS | True | - | - | default |

#### Router BGP Device Configuration

Expand Down
6 changes: 3 additions & 3 deletions ...ns/arista/avd/molecule/eos_config_deploy_cvp/documentation/devices/DC1-SVC3A.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1040,9 +1040,9 @@ ASN Notation: asplain

##### EVPN Peer Groups

| Peer Group | Activate | Encapsulation |
| ---------- | -------- | ------------- |
| EVPN-OVERLAY-PEERS | True | default |
| Peer Group | Activate | Route-map In | Route-map Out | Encapsulation |
| ---------- | -------- | ------------ | ------------- | ------------- |
| EVPN-OVERLAY-PEERS | True | - | - | default |

#### Router BGP VLAN Aware Bundles

Expand Down
6 changes: 3 additions & 3 deletions ...ns/arista/avd/molecule/eos_config_deploy_cvp/documentation/devices/DC1-SVC3B.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1013,9 +1013,9 @@ ASN Notation: asplain

##### EVPN Peer Groups

| Peer Group | Activate | Encapsulation |
| ---------- | -------- | ------------- |
| EVPN-OVERLAY-PEERS | True | default |
| Peer Group | Activate | Route-map In | Route-map Out | Encapsulation |
| ---------- | -------- | ------------ | ------------- | ------------- |
| EVPN-OVERLAY-PEERS | True | - | - | default |

#### Router BGP VLAN Aware Bundles

Expand Down
7 changes: 6 additions & 1 deletion ...a/avd/molecule/eos_designs-mpls-isis-sr-ldp/documentation/devices/SITE1-LER1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,10 +560,15 @@ router ospf 19 vrf TENANT_B_INTRA
| Router-ID | 100.70.0.5 |
| Log Adjacency Changes | True |
| MPLS LDP Sync Default | True |
| Local Convergence Delay (ms) | 15000 |
| Advertise Passive-only | True |
| SR MPLS Enabled | True |

#### ISIS Route Timers

| Settings | Value |
| -------- | ----- |
| Local Convergence Delay | 15000 milliseconds |

#### ISIS Interfaces Summary

| Interface | ISIS Instance | ISIS Metric | Interface Mode |
Expand Down
7 changes: 6 additions & 1 deletion ...a/avd/molecule/eos_designs-mpls-isis-sr-ldp/documentation/devices/SITE1-LER2.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,10 +525,15 @@ ip route vrf MGMT 0.0.0.0/0 192.168.200.5
| Router-ID | 100.70.0.6 |
| Log Adjacency Changes | True |
| MPLS LDP Sync Default | True |
| Local Convergence Delay (ms) | 15000 |
| Advertise Passive-only | True |
| SR MPLS Enabled | True |

#### ISIS Route Timers

| Settings | Value |
| -------- | ----- |
| Local Convergence Delay | 15000 milliseconds |

#### ISIS Interfaces Summary

| Interface | ISIS Instance | ISIS Metric | Interface Mode |
Expand Down
7 changes: 6 additions & 1 deletion ...a/avd/molecule/eos_designs-mpls-isis-sr-ldp/documentation/devices/SITE1-LSR1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,10 +333,15 @@ ip route vrf MGMT 0.0.0.0/0 192.168.200.5
| Router-ID | 100.70.0.1 |
| Log Adjacency Changes | True |
| MPLS LDP Sync Default | True |
| Local Convergence Delay (ms) | 15000 |
| Advertise Passive-only | True |
| SR MPLS Enabled | True |

#### ISIS Route Timers

| Settings | Value |
| -------- | ----- |
| Local Convergence Delay | 15000 milliseconds |

#### ISIS Interfaces Summary

| Interface | ISIS Instance | ISIS Metric | Interface Mode |
Expand Down
7 changes: 6 additions & 1 deletion ...a/avd/molecule/eos_designs-mpls-isis-sr-ldp/documentation/devices/SITE1-LSR2.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,10 +309,15 @@ ip route vrf MGMT 0.0.0.0/0 192.168.200.5
| Router-ID | 100.70.0.2 |
| Log Adjacency Changes | True |
| MPLS LDP Sync Default | True |
| Local Convergence Delay (ms) | 15000 |
| Advertise Passive-only | True |
| SR MPLS Enabled | True |

#### ISIS Route Timers

| Settings | Value |
| -------- | ----- |
| Local Convergence Delay | 15000 milliseconds |

#### ISIS Interfaces Summary

| Interface | ISIS Instance | ISIS Metric | Interface Mode |
Expand Down
7 changes: 6 additions & 1 deletion ...ta/avd/molecule/eos_designs-mpls-isis-sr-ldp/documentation/devices/SITE1-RR1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,10 +288,15 @@ ip route vrf MGMT 0.0.0.0/0 192.168.200.5
| Router-ID | 100.70.0.8 |
| Log Adjacency Changes | True |
| MPLS LDP Sync Default | True |
| Local Convergence Delay (ms) | 15000 |
| Advertise Passive-only | True |
| SR MPLS Enabled | True |

#### ISIS Route Timers

| Settings | Value |
| -------- | ----- |
| Local Convergence Delay | 15000 milliseconds |

#### ISIS Interfaces Summary

| Interface | ISIS Instance | ISIS Metric | Interface Mode |
Expand Down
Loading
Loading