-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing two Bugs #24
Fixing two Bugs #24
Conversation
* Sat Jan 05 2013 Adam Spiers <[email protected]> - 0.8.8.323.gd143501.250-1 | ||
- first version | ||
* Thu Oct 10 2013 [email protected] | ||
- 0.9.1.55.gbdd3b79.203 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was there a good reason for changing the placement of the version string?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I adapted those changements from the most recent adaption of your script in the pacman repository. But now that I look at it, it doesn't even make any good sense. So those changements are not from me and I don't seee any good reason for it. I simply took the source from th pacman repo and fixed the bugs in install-spotify.sh and spotify-client.spec . And yes, it is a good idea to accept it as a short-term fix, because spotify is a popular programm and people will get driven away from opensuse if there is an installer-script in the internet which doesn't work with the newest version of the distribution.
Thanks and have a nice day!
Thanks. This is not the way I want to go longer term but I suppose it makes sense to merge this as a short-term fix. But it would be nice to iron out the |
@guitargeek I was hoping you could fix the |
@guitargeek You would need to amend the commit in your local branch and then |
Superceded by #37. |
Hi,
i fixed the Bugs someone described here: #23
My solution is close to the solution someone proposed in post #3 on the issue-tracker above.
Cheers,
Jonas