Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing two Bugs #24

Closed
wants to merge 3 commits into from
Closed

Fixing two Bugs #24

wants to merge 3 commits into from

Conversation

guitargeek
Copy link

Hi,

i fixed the Bugs someone described here: #23

My solution is close to the solution someone proposed in post #3 on the issue-tracker above.

Cheers,
Jonas

* Sat Jan 05 2013 Adam Spiers <[email protected]> - 0.8.8.323.gd143501.250-1
- first version
* Thu Oct 10 2013 [email protected]
- 0.9.1.55.gbdd3b79.203
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there a good reason for changing the placement of the version string?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I adapted those changements from the most recent adaption of your script in the pacman repository. But now that I look at it, it doesn't even make any good sense. So those changements are not from me and I don't seee any good reason for it. I simply took the source from th pacman repo and fixed the bugs in install-spotify.sh and spotify-client.spec . And yes, it is a good idea to accept it as a short-term fix, because spotify is a popular programm and people will get driven away from opensuse if there is an installer-script in the internet which doesn't work with the newest version of the distribution.
Thanks and have a nice day!

@aspiers
Copy link
Owner

aspiers commented Feb 5, 2014

Thanks. This is not the way I want to go longer term but I suppose it makes sense to merge this as a short-term fix. But it would be nice to iron out the %changelog format question above first.

@aspiers
Copy link
Owner

aspiers commented Feb 15, 2014

@guitargeek I was hoping you could fix the %changelog issue so that I can merge this.

@aspiers
Copy link
Owner

aspiers commented Feb 15, 2014

@guitargeek You would need to amend the commit in your local branch and then git push -f to your github repository.

@aspiers
Copy link
Owner

aspiers commented Apr 22, 2015

Superceded by #37.

@aspiers aspiers closed this Apr 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants