-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing two Bugs #24
Closed
Closed
Fixing two Bugs #24
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,7 +13,7 @@ | |
| # published by the Open Source Initiative. | ||
|
|
||
| Name: spotify-client | ||
| Version: 0.8.8.323.gd143501.250 | ||
| Version: 0.9.4.183.g644e24e.428 | ||
| Release: 1 | ||
| License: Commercial | ||
| Summary: Desktop client for Spotify streaming music service | ||
|
|
@@ -113,7 +113,7 @@ EOF | |
|
|
||
| # fix libraries | ||
| mkdir -p %{buildroot}%{spotifylibdir} | ||
| ln -sf ../libcef.so %{buildroot}%{spotifylibdir}/libcef.so | ||
| ln -sf ../Data/libcef.so %{buildroot}%{spotifylibdir}/libcef.so | ||
|
|
||
| # install binary wrapper | ||
| mkdir -p %{buildroot}%{_bindir} | ||
|
|
@@ -182,6 +182,9 @@ fi | |
| #%{_datadir}/applications/spotify.desktop | ||
|
|
||
| %changelog | ||
| * Thu Jul 18 2013 Stefan Botter <[email protected]> | ||
| - update to 0.9.1, fix PM-78 | ||
|
|
||
| * Sat Jan 05 2013 Adam Spiers <[email protected]> | ||
| - add README | ||
|
|
||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,8 +5,8 @@ | |
| # | ||
|
|
||
| Name: spotify-installer | ||
| Version: 0.8.8.323.gd143501.250 | ||
| Release: 2 | ||
| Version: 0.9.4.183.g644e24e.428 | ||
| Release: 1.2 | ||
| License: MIT | ||
| Summary: Installer for Spotify desktop client | ||
| Url: https://github.com/aspiers/opensuse-spotify-installer/ | ||
|
|
@@ -51,9 +51,12 @@ install -D -m 755 README.html %{buildroot}%{_docdir}/%{name} | |
| %doc README.html | ||
|
|
||
| %changelog | ||
| * Sat Jan 05 2013 Adam Spiers <[email protected]> - 0.8.8.323.gd143501.250-2 | ||
| - update README | ||
| - add Requires: sudo | ||
|
|
||
| * Sat Jan 05 2013 Adam Spiers <[email protected]> - 0.8.8.323.gd143501.250-1 | ||
| - first version | ||
| * Thu Oct 10 2013 [email protected] | ||
| - 0.9.1.55.gbdd3b79.203 | ||
| * Sat Jan 5 2013 Adam Spiers <[email protected]> | ||
| - 0.8.8.323.gd143501.250-2 | ||
| * update README | ||
| * add Requires: sudo | ||
| * Sat Jan 5 2013 Adam Spiers <[email protected]> | ||
| - 0.8.8.323.gd143501.250-1 | ||
| * first version | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was there a good reason for changing the placement of the version string?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I adapted those changements from the most recent adaption of your script in the pacman repository. But now that I look at it, it doesn't even make any good sense. So those changements are not from me and I don't seee any good reason for it. I simply took the source from th pacman repo and fixed the bugs in install-spotify.sh and spotify-client.spec . And yes, it is a good idea to accept it as a short-term fix, because spotify is a popular programm and people will get driven away from opensuse if there is an installer-script in the internet which doesn't work with the newest version of the distribution.
Thanks and have a nice day!