refactor(appengine): extract complex queries #1056
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
noaccOS
force-pushed
the
push-unlstvytkmyv
branch
from
b6f6b3a to
b5335b0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1056 +/- ##
==========================================
+ Coverage 69.23% 69.84% +0.60%
==========================================
Files 275 254 -21
Lines 7193 5564 -1629
==========================================
- Hits 4980 3886 -1094
+ Misses 2213 1678 -535 ☔ View full report in Codecov by Sentry. |
noaccOS
force-pushed
the
push-unlstvytkmyv
branch
3 times, most recently
from
33f00a5 to
3954ba7
Compare
Annopaolo
reviewed
Jan 29, 2025
Comment on lines
+154
to
+176
| defp clean_device_introspection(device) do | ||
| introspection_major = device.introspection || %{} | ||
| introspection_minor = device.introspection_minor || %{} | ||
|
|
||
| major_keys = introspection_major |> Map.keys() |> MapSet.new() | ||
| minor_keys = introspection_minor |> Map.keys() |> MapSet.new() | ||
|
|
||
| corrupted = MapSet.symmetric_difference(major_keys, minor_keys) |> MapSet.to_list() | ||
|
|
||
| for interface <- corrupted do | ||
| device_id = Device.encode_device_id(device.device_id) | ||
|
|
||
| Logger.error("Introspection has either major or minor, but not both. Corrupted entry?", | ||
| interface: interface, | ||
| device_id: device_id | ||
| ) | ||
| end | ||
|
|
||
| introspection_major = introspection_major |> Map.drop(corrupted) | ||
| introspection_minor = introspection_minor |> Map.drop(corrupted) | ||
|
|
||
| {introspection_major, introspection_minor} | ||
| end |
There was a problem hiding this comment.
Why is this needed? It seems we're adding some defensive code against possible database corruptions, but it would be better handled by crashing
| @@ -1,4 +1,4 @@ | |||
| [ | |||
| import_deps: [:phoenix, :ecto, :skogsra, :stream_data], | |||
| import_deps: [:phoenix, :ecto, :skogsra], | |||
There was a problem hiding this comment.
As in #1055, I would not remove the :stream_data formatter
this allows calling `mix format` in dev Signed-off-by: Francesco Noacco <[email protected]>
noaccOS
force-pushed
the
push-unlstvytkmyv
branch
4 times, most recently
from
9cdb892 to
2587c48
Compare
The first installment in the effort of refactoring the device module. The change can be made little by little as exandra and cqex queries can coexist. This change ports a few queries to exandra, without making any big logic refactor, but we can see the future direction of this refactor: Astarte.AppEngine.API.Device.Queries becomes a module to expose _queries_ and not data from the database directly. For this iteration, this is enough to elegantly use the queries in the Device module, but more complex queries may require a more in-depth refactor. The following queries have been ported: - `retrieve_interfaces_list` - `retrieve_all_endpoints_for_interface!` - `retrieve_mapping` - `prepare_value_type_query` / `execute_value_type_query` Signed-off-by: Francesco Noacco <[email protected]>
- create a new module `Data`, which holds complex database operations - the device_status_from device query has been refactored under DeviceStatus. Signed-off-by: Francesco Noacco <[email protected]>
noaccOS
force-pushed
the
push-unlstvytkmyv
branch
from
2587c48 to
c65f9b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data, which holds complex database operationsDeviceStatus.depends on #1055
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g. usage docs, diagrams, etc.: