Update DepositTx for monorepo #1410 #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joroshiba
reviewed
Sep 9, 2024
joroshiba
approved these changes
Sep 11, 2024
github-merge-queue bot
pushed a commit
to astriaorg/astria
that referenced
this pull request
Sep 11, 2024
…1410) ## Summary Added `id_of_source_transaction` and `position_in_source_transaction` to `Deposit`. ## Background Previous deposit events had no information about the deposit source, so rollups could not trace if their deposits had landed without checking the balance. Additionally, this could result in deposit txs having the same hash in the EVM. ## Changes - Created primitive proto type `TransactionId` for identifying source transaction in deposits. - Added `id_of_source_transaction` and `position_in_source_transaction` to `Deposit`. - Included tx id in the ephemeral state via `current_source()` so that it can be accessed by actions. - Added accessors/mutators for deposit index to `StateReadExt` and `StateWriteExt` traits in `transaction`. - Updated `bridge_lock` and `ics20_transfer` actions to populate `Deposit` events with transaction id and index based on the state. ## Testing Added test to ensure `position_in_source_transaction` is incremented correctly. ## Breaking Changelist - App hash changed because of increasing block fees due to longer length of `Deposit`. - Changed SequencerBlock API `Deposit` event, having two new mandatory fields `source_transaction_id` and `source_action_index`. `source_transaction_id` uses a new primitive proto type `TransactionId`. ## Related Issues with astriaorg/astria-geth#42, closes #1402 --------- Co-authored-by: Jordan Oroshiba <[email protected]> Co-authored-by: Fraser Hutchison <[email protected]> Co-authored-by: jesse snyder <[email protected]>
github-merge-queue bot
pushed a commit
to astriaorg/astria
that referenced
this pull request
Sep 11, 2024
## Summary Update geth tag to `latest` for astriaorg/astria-geth#42 ## Background #1410 required changes to `astria-geth`, which necessitated changing the geth dev tag to be the specific PR number. Now that the geth PR is merged, we can bump the tag. ## Changes - Changed `evm-rollup` geth dev tag to `latest` and bumped chart versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
astriaorg/astria#1410 changes the
Depositmessage in thesequencer_blockAPI, necessitating changes toDepositTxin Geth