feat(proto, core, sequencer)!: add traceability to rollup deposits #1410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
proto
ethanoroshiba
requested review from
a team,
joroshiba,
SuperFluffy and
noot
as code owners
noot
reviewed
Aug 28, 2024
noot
reviewed
Aug 28, 2024
SuperFluffy
approved these changes
Sep 4, 2024
joroshiba
reviewed
Sep 9, 2024
proto/sequencerblockapis/astria/sequencerblock/v1alpha1/block.proto
Outdated
Show resolved
Hide resolved
proto/sequencerblockapis/astria/sequencerblock/v1alpha1/block.proto
Outdated
Show resolved
Hide resolved
|
Please expand on the list of breaking changes explaining why this is breaking the app hash. |
joroshiba
approved these changes
Sep 11, 2024
ethanoroshiba
added a commit
to astriaorg/astria-geth
that referenced
this pull request
Sep 11, 2024
astriaorg/astria#1410 changes the `Deposit` message in the `sequencer_block` API, necessitating changes to `DepositTx` in Geth
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 11, 2024
## Summary Update geth tag to `latest` for astriaorg/astria-geth#42 ## Background #1410 required changes to `astria-geth`, which necessitated changing the geth dev tag to be the specific PR number. Now that the geth PR is merged, we can bump the tag. ## Changes - Changed `evm-rollup` geth dev tag to `latest` and bumped chart versions.
This was referenced Sep 16, 2024
steezeburger
added a commit
that referenced
this pull request
Sep 23, 2024
* main: feat(sequencer): make mempool balance aware (#1408) chore(sequencer): change test addresses to versions with known private keys (#1487) chore(chart): update geth tag (#1485) feat(sequencer): report deposit events (#1447) feat(proto, core, sequencer)!: add traceability to rollup deposits (#1410) fix(bridge-withdrawer, cli, sequencer-client): migrate from `broadcast_tx_commit` to `broadcast_tx_sync` (#1376) fix(sequencer): add `end_block` to `app_execute_transaction_with_every_action_snapshot` (#1455) release: end of iteration release cuts (#1456) chore(charts): rollupName templates (#1458) chore(sequencer-relayer): Add instrumentation (#1375) feat(proto, core, sequencer)!: permit bech32 compatible addresses (#1425) chore: memoize `address_bytes` of verification key (#1444) chore(ci): include `ibc-bridge-test` in `docker` CI target (#1438) chore(charts): bump celestia versions (#1431)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added
id_of_source_transactionandposition_in_source_transactiontoDeposit.Background
Previous deposit events had no information about the deposit source, so rollups could not trace if their deposits had landed without checking the balance. Additionally, this could result in deposit txs having the same hash in the EVM.
Changes
TransactionIdfor identifying source transaction in deposits.id_of_source_transactionandposition_in_source_transactiontoDeposit.current_source()so that it can be accessed by actions.StateReadExtandStateWriteExttraits intransaction.bridge_lockandics20_transferactions to populateDepositevents with transaction id and index based on the state.Testing
Added test to ensure
position_in_source_transactionis incremented correctly.Breaking Changelist
Deposit.Depositevent, having two new mandatory fieldssource_transaction_idandsource_action_index.source_transaction_iduses a new primitive proto typeTransactionId.Related Issues
with astriaorg/astria-geth#42, closes #1402