fix(docker): use target binary build param as name of image entrypoint #1573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joroshiba
approved these changes
Sep 27, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
steezeburger
added a commit
that referenced
this pull request
Oct 7, 2024
* main: (34 commits) feat(proto): add bundle and optimistic block apis (#1519) feat(sequencer)!: make empty transactions invalid (#1609) chore(sequencer): simplify boolean expressions in `transaction container` (#1595) refactor(cli): merge argument parsing and command execution (#1568) feat(charts): astrotrek chart (#1513) chore(charts): genesis template to support latest changes (#1594) fix(ci): code freeze action fix (#1610) chore(sequencer)!: exclusively use Borsh encoding for stored data (ENG-768) (#1492) ci: code freeze through github actions (#1588) refactor(sequencer): use builder pattern for transaction container tests (#1592) feat(conductor)!: implement chain ID checks (#1482) chore(ci): upgrade audit-check (#1577) feat(sequencer)!: transaction categories on UnsignedTransaction (#1512) fix(charts): sequencer prometheus rules (#1598) chore(all): Migrate all instances of `#[allow]` to `#[expect]` (#1561) chore(charts,sequencer-faucet): asset precision (#1517) chore(docs): endpoints (#1543) fix(docker): use target binary build param as name of image entrypoint (#1573) fix(ci): ibc bridge test timeout (#1587) Feature: Add `graph-node` to charts. (#1489) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes container images to use the
$TARGETBINARYbuild param as the name of the binary run in the image entrypoint.Background
Before this patch, the containerfile entrypoint used a symlinked
/usr/local/bin/entrypointas the entrypoint, which caused the name of the binary to be"entrypoint". This itself was to workaround to theENTRYPOINTcommand not allowing for variables in exec form. This patch instead creates an ad-hoc script which itself executes$TARGETBINARY, and uses this script as the entrypoint.Together with the script using
execand the exec form ofENTRYPOINTthe expected binary (and process) name are used.Taking
astria-cli's help message as an example:Before:
After:
Changes
/usr/local/bin/entrypoint.shscript incontainerfiles/Dockerfilewhich is used as a new entrypoint and executes$TARGETBINARYTesting
Built and ran images using the dockerfile. No functionality was changed but the binary is
$TARGETBINARYand notentrypointnow.Related Issues
closes #1571