Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docker): use target binary build param as name of image entrypoint #1573

Merged
merged 2 commits into from
Sep 30, 2024
Merged

fix(docker): use target binary build param as name of image entrypoint #1573

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b472e1
feat(docker): use $TARGETBINARY as the executable name
SuperFluffy Sep 26, 2024
adc3ba4
comment dockerfile oddity
SuperFluffy Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions containerfiles/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,5 +82,10 @@ RUN \
apt-get clean; \
rm -rf /var/lib/apt/lists/*;
COPY --from=builder /build/release/$TARGETBINARY /usr/local/bin/$TARGETBINARY
RUN ln -s /usr/local/bin/$TARGETBINARY /usr/local/bin/entrypoint
ENTRYPOINT ["/usr/local/bin/entrypoint"]

# HACK: Ensure that $TARGETBINARY is the binary name.
ENV TARGETBINARY=$TARGETBINARY
RUN \
printf '#!/bin/sh\nexec /usr/local/bin/$TARGETBINARY $@\n' > /usr/local/bin/entrypoint.sh; \
chmod +x /usr/local/bin/entrypoint.sh;
ENTRYPOINT ["/usr/local/bin/entrypoint.sh"]
Loading