-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos-modules: move virtiofsd from host to microvm #291
Conversation
994a189
to
5566068
Compare
Lgtm, did not test |
How should the migration be done. All vms need to be stopped, mcirovm on the host needs to be updated, all vms need to be rebuilt and started. |
No urgent requirement to stop VMs but they must be updated before they can be started again. Hence the warning that is output on host activation. My hope is that VMs are updated more frequently than hosts. |
How about a check if the scripts exists and if yes output that a rebuild is required. |
Or create a new major release. |
…pervisordConfigFile with generators.toINI
I am not sure I understand, the activationScript snippet does check for the scripts' existence.
I've prepared the CHANGELOG.md entries for that but let's wait a bit for any regressions. |
@SuperSandro2000 Can you review pls? Note the simplified
virtiofsdCount
logic.