Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos-modules: move virtiofsd from host to microvm #291

Merged
merged 9 commits into from
Dec 3, 2024
Merged

nixos-modules: move virtiofsd from host to microvm #291

merged 9 commits into from
Dec 3, 2024

Conversation

astro
Copy link
Owner

@astro astro commented Oct 26, 2024

@SuperSandro2000 Can you review pls? Note the simplified virtiofsdCount logic.

nixos-modules/host/default.nix Outdated Show resolved Hide resolved
nixos-modules/microvm/virtiofsd/default.nix Outdated Show resolved Hide resolved
@astro astro force-pushed the virtiofsd branch 2 times, most recently from 994a189 to 5566068 Compare November 27, 2024 02:16
nixos-modules/microvm/virtiofsd/default.nix Outdated Show resolved Hide resolved
@MarcelCoding
Copy link
Contributor

Lgtm, did not test

@MarcelCoding
Copy link
Contributor

MarcelCoding commented Dec 1, 2024

How should the migration be done. All vms need to be stopped, mcirovm on the host needs to be updated, all vms need to be rebuilt and started.

@astro
Copy link
Owner Author

astro commented Dec 3, 2024

How should the migration be done. All vms need to be stopped, mciro m in the host needs to be updated, all vms need to be rebuild and started

No urgent requirement to stop VMs but they must be updated before they can be started again. Hence the warning that is output on host activation. My hope is that VMs are updated more frequently than hosts.

@MarcelCoding
Copy link
Contributor

MarcelCoding commented Dec 3, 2024

How about a check if the scripts exists and if yes output that a rebuild is required.

@MarcelCoding
Copy link
Contributor

Or create a new major release.

@astro astro merged commit 746008e into main Dec 3, 2024
37 of 53 checks passed
@astro astro deleted the virtiofsd branch December 3, 2024 17:46
@PatrickDaG PatrickDaG mentioned this pull request Dec 3, 2024
@astro
Copy link
Owner Author

astro commented Dec 5, 2024

How about a check if the scripts exists and if yes output that a rebuild is required.

I am not sure I understand, the activationScript snippet does check for the scripts' existence.

Or create a new major release.

I've prepared the CHANGELOG.md entries for that but let's wait a bit for any regressions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants