Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI wrt broken coverage upload artifact #1210

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Conversation

pankajkoti
Copy link
Contributor

Apparently the GitHub action https://github.com/actions/upload-artifact released a breaking change actions/upload-artifact#602 (not following semver guidelines) which is affecting our CodeCov job as it's no longer
able to download artifacts that were supposed to be uploaded from our tests in earlier jobs in the CI.

According to suggestion in https://github.com/actions/upload-artifact/pull/607/files, set include include-hidden-files: true, so that our workflow continues to work as it was before.

(cherry picked from commit 1851bb177ef3b6de9aed08a98d5e3f2d624a3701)
Copy link

netlify bot commented Sep 19, 2024

Deploy Preview for sunny-pastelito-5ecb04 canceled.

Name Link
🔨 Latest commit 5695410
🔍 Latest deploy log https://app.netlify.com/sites/sunny-pastelito-5ecb04/deploys/66ebff0fb2893d00095774f1

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 19, 2024
@tatiana tatiana marked this pull request as ready for review September 19, 2024 10:38
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 19, 2024
@tatiana tatiana merged commit c5e8544 into main Sep 19, 2024
5 checks passed
@tatiana tatiana deleted the ci-fix-upload-artifact branch September 19, 2024 10:38
@dosubot dosubot bot added the area:ci Related to CI, Github Actions, or other continuous integration tools label Sep 19, 2024
@tatiana tatiana added this to the Cosmos 1.7.0 milestone Sep 21, 2024
ags-de pushed a commit to ags-de/astronomer-cosmos that referenced this pull request Sep 24, 2024
Apparently the GitHub action https://github.com/actions/upload-artifact
released a breaking change
actions/upload-artifact#602 (not following
semver guidelines) which is affecting our CodeCov job as it's no longer
able to download artifacts that were supposed to be uploaded from our
tests in earlier jobs in the CI.

According to suggestion in
https://github.com/actions/upload-artifact/pull/607/files, set include
include-hidden-files: true, so that our workflow continues to work as it
was before.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:ci Related to CI, Github Actions, or other continuous integration tools lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants