-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
APE 24: Astropy Affiliated Packages with pyOpenSci (now APE 22) #87
Conversation
Co-authored-by: Leah Wasser <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: Erik Tollerud <[email protected]>
Co-authored-by: Erik Tollerud <[email protected]>
Alright, I'm happy with this, as is the rest of the coco. Merging! |
Oops, I was supposed to do the decision rationale, etc in this PR but I'll just do it directly in main instead. My bad. |
Thanks, all! |
Not also this was renumbered to APE22 in 6964140 |
Wait... why is the APE number changed? |
APE 22 is already claimed but just not merged: Any chance you can change this back to original APE 24 to avoid confusion? |
Also there is a typo in the rationale: |
@lwasser - I think I found the right ORCiD for you in https://doi.org/10.5281/zenodo.10581891, but let me know if any of that is wrong and I can fix the metadata! |
The procedure in the README covers this @pllim - the numbering is in merging order. the numbering prior to merging is to be thought of as preliminary. (The backstory is that we were struggling with deciding what to do here, and then we wrote it into the instructions and no one seemed to mind... So if we want to change that it's just a matter of changing the README instructions. I don't have a terribly strong opinion other than "we should make sure the instructions are explicit about it and follow whatever they say at any given time") |
🤪 |
I suppose the final renaming is only done right in the merge commit then – any special tricks how to do this? |
Initial authors: @pllim @lwasser @WilliamJamieson @dhomeier
TODO