DG-1442 Modification of the PreProcessor for Custom Sort - Bulk Update Edge Cases #3198

hr2904 · 2024-06-05T06:24:17Z

Change description

Glossary Entities can be created/modified from non-FE methods as well, so we needed to add logic to add appropriate lexicographicalSortOrder Attribute to the entity in case it is not sent from user.
Also added validation regarding valid and appropriate lexoranks in context to the entity being sent.

Type of change

New feature (adds functionality)

Related Docs

Ticket
TestCases

Checklists

Development

Lint rules pass locally
Application changes have been tested thoroughly
Automated tests covering modified code pass

Security

Security impact of change has been considered
Code follows company security practices and guidelines

Code review

Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
"Ready for review" label attached and reviewers assigned
Changes have been reviewed by at least one other contributor
Pull request linked to task tracker where applicable

Logging

Fix policy not updating issue

…ogress flag , still in progress.

DG-1235 Persona type change

…7-migrations2 # Conflicts: # repository/src/main/java/org/apache/atlas/repository/store/graph/v2/DataDomainQNMigrationService.java # repository/src/main/java/org/apache/atlas/repository/store/graph/v2/MigrationService.java # repository/src/main/java/org/apache/atlas/repository/store/graph/v2/preprocessor/PreProcessorUtils.java # repository/src/main/java/org/apache/atlas/repository/store/graph/v2/preprocessor/datamesh/AbstractDomainPreProcessor.java # repository/src/main/java/org/apache/atlas/repository/store/graph/v2/preprocessor/datamesh/DataDomainPreProcessor.java # repository/src/main/java/org/apache/atlas/repository/store/graph/v2/preprocessor/datamesh/DataProductPreProcessor.java # webapp/src/main/java/org/apache/atlas/web/rest/MigrationREST.java

Dg 1297 migrations2

Fixed a missed check for dataProduct

DG-1235 Fix persona alias extraction issue

DG-1235 Stakeholder preprocessor

DG-1235 Skip initial auth checks

DG-1235 save domain qualified names for Stakeholder title

Fixed bootstrap default StakeholderTitles

Fixed StakeholderTitles to Stakeholer relationship permission

Beta sync helper

Stakeholer beta

Constants chnage

DG-1235 Fix title update 403

DG-1235 Fix Stakeholder update issue

DG-1235 Title update 403

Beta sync helper

…moving the attribute from the vertex.

# Conflicts: # repository/src/main/java/org/apache/atlas/repository/store/graph/v2/preprocessor/PreProcessorUtils.java # repository/src/main/java/org/apache/atlas/repository/store/graph/v2/preprocessor/glossary/CategoryPreProcessor.java # repository/src/main/java/org/apache/atlas/repository/store/graph/v2/preprocessor/glossary/GlossaryPreProcessor.java # repository/src/main/java/org/apache/atlas/repository/store/graph/v2/preprocessor/glossary/TermPreProcessor.java

DG-1442 Fixed a minor bug where an empty lexo attribute in update call was removed from vertex

DG-1476 handle review comments

…date call was removed from vertex"

Revert "DG-1442 Fixed a minor bug where an empty lexo attribute in update call was removed from vertex"

…onship-permission Update sub domain remove relationship permission

…moving the attribute from the vertex

DG-1442 Fixed a minor bug where an empty lexo attribute in update call was re…

Revert "DG-1476 handle review comments"

…onship-permission update sub domain remove relationship permission

…mission

DG-1533 Fix remove-relationship permission with sub-domain update permission

...src/main/java/org/apache/atlas/repository/store/graph/v2/preprocessor/PreProcessorUtils.java

...a/org/apache/atlas/repository/store/graph/v2/preprocessor/glossary/GlossaryPreProcessor.java

...a/org/apache/atlas/repository/store/graph/v2/preprocessor/glossary/CategoryPreProcessor.java

.../java/org/apache/atlas/repository/store/graph/v2/preprocessor/glossary/TermPreProcessor.java

nikhilbonte21 · 2024-06-18T11:52:04Z

...ache/atlas/repository/store/graph/v2/preprocessor/glossary/AbstractGlossaryPreProcessor.java

 import org.apache.atlas.tasks.TaskManagement;
 import org.apache.atlas.type.AtlasEntityType;
 import org.apache.atlas.type.AtlasTypeRegistry;
+import org.apache.atlas.util.lexoRank.LexoRank;
 import org.apache.atlas.utils.AtlasPerfMetrics;
 import org.apache.commons.collections.CollectionUtils;
 import org.apache.commons.lang.StringUtils;


Revert changes in this file to avoid this in PR

nikhilbonte21 · 2024-06-18T12:45:41Z

I think we will need to handle restore of GCTs as well. Let us discuss this once you resolve other comments & do a sanity testing

nikhilbonte21 and others added 30 commits May 9, 2024 01:14

Merge pull request #3024 from atlanhq/meshQualifiedName

7cfe37c

Logging

Merge pull request #3025 from atlanhq/meshQualifiedName

5f3dcf1

Fix policy not updating issue

Merge branch 'master' into beta

1899860

Merge branch 'DQ-161' into beta

96de287

Migration API working correctly, use of redis for setting tracking pr…

032a347

…ogress flag , still in progress.

Updated PreProcessorUtils Constants as per PR #2979

c6aa50b

Migration API working correctly, use of redis for setting tracking pr…

bff02a3

…ogress flag , still in progress.

Merge pull request #3029 from atlanhq/nb/stakeholder

f8a7b13

DG-1235 Persona type change

Added Redis impl and fixed some logical issues.

47d8595

Merge pull request #3028 from atlanhq/dg-1297-migrations2

0f4e752

Dg 1297 migrations2

Fixed a missed check for dataProduct

edebf12

Merge pull request #3030 from atlanhq/dg-1297-migrations2

aa08caf

Fixed a missed check for dataProduct

Merge pull request #3031 from atlanhq/nb/stakeholder

61ff773

DG-1235 Fix persona alias extraction issue

Merge pull request #3032 from atlanhq/nb/stakeholder

1b6a3bf

DG-1235 Stakeholder preprocessor

Merge pull request #3033 from atlanhq/nb/stakeholder

0fc3521

DG-1235 Skip initial auth checks

Merge pull request #3034 from atlanhq/nb/stakeholder

f1cfbd9

DG-1235 save domain qualified names for Stakeholder title

Merge pull request #3035 from atlanhq/nb/stakeholder

15ee0a5

Fixed bootstrap default StakeholderTitles

Merge pull request #3036 from atlanhq/nb/stakeholder

d83bd92

Fixed StakeholderTitles to Stakeholer relationship permission

Merge branch 'master' into beta-sync-helper

5042ec0

Merge pull request #3042 from atlanhq/beta-sync-helper

408e151

Beta sync helper

Merge branch 'nb/stakeholder' into stakeholer-beta

ddab55c

Merge pull request #3043 from atlanhq/stakeholer-beta

de3cf8b

Stakeholer beta

Constants chnage

2bd23ff

Merge pull request #3044 from atlanhq/stakeholer-beta

4b74eba

Constants chnage

Merge pull request #3048 from atlanhq/nb/stakeholder

4f4ca02

DG-1235 Fix title update 403

Merge pull request #3049 from atlanhq/nb/stakeholder

24a42ce

DG-1235 Fix Stakeholder update issue

Merge pull request #3051 from atlanhq/nb/stakeholder

ea9c742

DG-1235 Title update 403

Merge branch 'master' into beta-sync-helper

813584d

Merge pull request #3061 from atlanhq/beta-sync-helper

9f2db90

Beta sync helper

Fixed a minor bug where an empty lexo attribute in update call was re…

de75af0

…moving the attribute from the vertex.

hr2904 force-pushed the DG-1442_2 branch from 324c134 to de75af0 Compare June 14, 2024 07:50

hr2904 and others added 19 commits June 14, 2024 13:40

Merge pull request #3249 from atlanhq/beta-1442-helper

f8fed06

DG-1442 Fixed a minor bug where an empty lexo attribute in update call was removed from vertex

handle review comments

77d458a

handle review comments

27bce0c

Merge branch 'beta' into DG-1476-beta-1

d3f7554

Merge pull request #3250 from atlanhq/DG-1476-beta-1

57b357b

DG-1476 handle review comments

Revert "DG-1442 Fixed a minor bug where an empty lexo attribute in up…

7c814ae

…date call was removed from vertex"

Merge pull request #3251 from atlanhq/revert-3249-beta-1442-helper

68b8f7e

Revert "DG-1442 Fixed a minor bug where an empty lexo attribute in update call was removed from vertex"

update sub domain remove relationship permission

3cd5afb

Merge pull request #3252 from atlanhq/update-sub-domain-remove-relati…

e8c22df

…onship-permission Update sub domain remove relationship permission

Fixed a minor bug where an empty lexo attribute in update call was re…

bf58c06

…moving the attribute from the vertex

Merge pull request #3253 from atlanhq/beta-1442-helper-2

2cd4605

DG-1442 Fixed a minor bug where an empty lexo attribute in update call was re…

Revert "DG-1476 handle review comments"

6f84427

Merge pull request #3254 from atlanhq/revert-3250-DG-1476-beta-1

51474f1

Revert "DG-1476 handle review comments"

update sub domain remove relationship permission

a2c91b7

Merge pull request #3255 from atlanhq/update-sub-domain-remove-relati…

f746dcd

…onship-permission update sub domain remove relationship permission

DG-1533 Fix remove-relationship permission with sub-domain update per…

15af608

…mission

Merge branch 'DG-1533' into beta-helper

a013616

Merge pull request #3258 from atlanhq/beta-helper

5d5919c

DG-1533 Fix remove-relationship permission with sub-domain update permission

nikhilbonte21 requested changes Jun 18, 2024

View reviewed changes

hr2904 added 2 commits June 19, 2024 11:56

Fixed PR comments

57fe38e

Reverted the AbstractGlossaryPreProcessor file , previously edited.

36e7c36

hr2904 force-pushed the DG-1442_2 branch from 28f4209 to 36e7c36 Compare June 19, 2024 06:26

hr2904 added the DO NOT MERGE label Jun 19, 2024

hr2904 closed this Jun 19, 2024

nikhilbonte21 mentioned this pull request Jun 20, 2024

DG-1442 Modification of the PreProcessor for Custom Sort - Bulk Update Edge Cases #3265

Merged

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DG-1442 Modification of the PreProcessor for Custom Sort - Bulk Update Edge Cases #3198

DG-1442 Modification of the PreProcessor for Custom Sort - Bulk Update Edge Cases #3198

hr2904 commented Jun 5, 2024 •

edited by nikhilbonte21

Loading

nikhilbonte21 Jun 18, 2024

nikhilbonte21 commented Jun 18, 2024

DG-1442 Modification of the PreProcessor for Custom Sort - Bulk Update Edge Cases #3198

DG-1442 Modification of the PreProcessor for Custom Sort - Bulk Update Edge Cases #3198

Conversation

hr2904 commented Jun 5, 2024 • edited by nikhilbonte21 Loading

Change description

Type of change

Related Docs

Checklists

Development

Security

Code review

nikhilbonte21 Jun 18, 2024

Choose a reason for hiding this comment

nikhilbonte21 commented Jun 18, 2024

hr2904 commented Jun 5, 2024 •

edited by nikhilbonte21

Loading