Strip query strings from imports when resolving #98
Conversation
mattcompiles
dismissed stale reviews from MonicaOlejniczak, tomgasson, and JakeLane
via
f3daf48
|
So it turns out that removing query params in just the babel-plugin causes issues when attempting to do manifest lookups as the query param will still be present inside the module graph. I've now updated the PR to strip query params in all places we reference a specifier/request. |
| @@ -116,3 +116,16 @@ export const buildManifest = ( | |||
| { publicPath, assets: {} } | |||
| ); | |||
| }; | |||
|
|
|||
| export const removeQueryParams = (input: string) => { | |||
There was a problem hiding this comment.
If it's duplicated 3 times it should probably be extracted somewhere, but I also don't know whether there's a suitable shared dependency all the usages could import from. The function is trivial enough that it's possibly not worth the additional effort (if there's no existing common RLL package that's available everywhere)
There was a problem hiding this comment.
I duplicated because there isn't a shared dep and I didn't think it was worth introducing one. In the past I've dealt with this by having internal dev deps that are compiled into the package. You need a build script capable of handing the externalisation logic though.
mattcompiles
dismissed stale reviews from MonicaOlejniczak and JakeLane
via
d3cc489
In some cases imports will contain query strings. The enhanced-resolver plugin for the "exports" field in package.json will fail to resolve these imports correctly. This change will string any query strings from the import before resolving it.
nr-tw
force-pushed
the
fix-issue-with-exports-and-query-strings
branch
from
d3cc489 to
e88eca9
Compare
In some cases imports will contain query strings. The enhanced-resolver plugin for the "exports" field in package.json will fail to resolve these imports correctly. This change will strip any query strings from the import before resolving it.
The actual use case for this is that with Parcel we have created a set of plugins that will support Webpack's "magic comments" for naming async chunks. The way this plugin works is taking the chunk name and appending it to the import, e.g.
import('@some/pkg?webpackChunkName=some-pkg'so it can later be accessed by a namer plugin.RLL will fail on these imports in the rare case that the package contains an
exportsfield, as the full string will be used to match so the query string will break things.Added a new failing test for this - note as per the comment I was unable to get it working as a "fixture" because it doesn't appear fixtures are processed as modules, so the
exportsfield wouldn't get used.