support non project root language servers #11
Conversation
… can override it
|
This branch is removed. Could you revive it? |
|
@UziTech Could you rebase this? This is needed for flow-ide |
| public determineProjectPath(textEditor: TextEditor): string | null { | ||
| const filePath = textEditor.getPath(); | ||
| if (filePath == null) { | ||
| return null; | ||
| } | ||
| return this._normalizedProjectPaths.find((d) => filePath.startsWith(d)) || null; | ||
| } | ||
|
|
||
| public updateNormalizedProjectPaths(): void { | ||
| this._normalizedProjectPaths = atom.project.getDirectories().map((d) => this.normalizePath(d.getPath())); | ||
| } | ||
|
|
||
| public normalizePath(projectPath: string): string { | ||
| return !projectPath.endsWith(path.sep) ? path.join(projectPath, path.sep) : projectPath; | ||
| } | ||
|
|
There was a problem hiding this comment.
I think we should just move this code to auto-languageclient (without modifying) so the user can override them. Maybe there is a better way to make this configurable instead of moving the methods
| @@ -263,6 +274,7 @@ export default class AutoLanguageClient { | |||
| (filepath) => this.filterChangeWatchedFiles(filepath), | |||
| this.reportBusyWhile, | |||
| this.getServerName(), | |||
| (e) => this.determineProjectPath(e), | |||
There was a problem hiding this comment.
Instead of all these, we can probably provide a method that is passed down to this._serverManager.
A property of AutoLanguageclient:
public customDetermineProject: undefined | (textEditor: TextEditor) => string | null = undefinedIf someone wants to use this, they should override it with a function. Later inside ServerManager.determineProject, we will check if this method is !== undefined, and if so we will use that instead.
|
I don't have this branch anymore. It would be easier for you to create a new PR that does this. |
|
Yeah, I think it's easier to start over |
moved from atom/atom-languageclient#250
see issue atom/atom-languageclient#233