feat: support out of the project files #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
aminya
changed the title
aminya
force-pushed
the
configuring-project-path
branch
from
e471c23
to
dba8dc1
Compare
Co-Authored-By: Alex Butler <[email protected]>
aminya
force-pushed
the
configuring-project-path
branch
from
dba8dc1
to
500d2d0
Compare
Co-Authored-By: Alex Butler <[email protected]>
This check is not necessary
aminya
force-pushed
the
configuring-project-path
branch
from
500d2d0
to
47773e9
Compare
|
We should add tests before this is merged. |
aminya
force-pushed
the
configuring-project-path
branch
from
d58b5e7
to
92da849
Compare
aminya
force-pushed
the
configuring-project-path
branch
from
92da849
to
bb2eefc
Compare
|
Ready to go |
UziTech
requested changes
Jun 11, 2021
UziTech
reviewed
Jun 11, 2021
test/auto-languageclient.test.ts
Outdated
| expect(projectPath).toBeNull() | ||
| }) | ||
| it("returns the project path when a file of that project is open", async () => { | ||
| // macos has issues with handling too much resources |
There was a problem hiding this comment.
is this just an issue on GitHub actions or would this crash Atom if run on a Mac?
There was a problem hiding this comment.
Because the number of tests is high, MacOS can't run all of them. It works fine if each of the tests runs in a single process. There is nothing OS-specific in the code, so this is a limitation of the operating system.
aminya
force-pushed
the
configuring-project-path
branch
2 times, most recently
from
724f538
to
42d2f3a
Compare
aminya
force-pushed
the
configuring-project-path
branch
from
42d2f3a
to
50fe3d8
Compare
UziTech
approved these changes
Jun 13, 2021
|
🎉 This PR is included in version 1.11.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
determineProjectPathtoAutoLanguageClientand passes it down toServerManagerin its constructor. (supercedes support non project root language servers #11)