Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: impl to create new enollments using APKAM-OTP #453

Merged
merged 54 commits into from
Dec 19, 2024
Merged

feat: impl to create new enollments using APKAM-OTP #453

merged 54 commits into from
Dec 19, 2024

Conversation

srieteja
Copy link
Contributor

@srieteja srieteja commented Nov 28, 2024 •
edited
Loading

Closes #451

- What I did

AtAuth changes

  • Implement auth_cli that can send enroll requests using OTP and cut an atKeys file once that enrollment is approved.
  • fix at_activate bug: at_activate crashes when the atsign does not start with '@'
  • Introduce a new flag 'v' that makes activate_cli and auth_cli more verbose
  • Introduce new params 'd', 'p', 'n' in arg_parser that parses device_name, app_name and namespaces from command-line

AtClient changes

  • Add a new param to atclient_pkam_authenticate() named 'err_msg' that is populated with the error message from the server in case of an error
  • Introduce new option in get_public_key_request_options named 'should_auth' that allows the user to specify if the key provided to 'atclient_get_public_key()' should be fetched with/without auth. Supporting getter, setter, init and free methods have also been implemented.

AtCommons changes

  • Introduce new method in atcommons/enroll_namespace.c that parses namespace list strings and returns a 'enroll_namespace_t' struct
  • fix bug: The length var in enroll_namespace_list_t struct defaults to SIZE_MAX. (Fixed, defaults to 0 now)

- How I did it

  • fix bug: The length var in enroll_namespace_list_t struct defaults to SIZE_MAX: In 'atcommons_enroll_namespace_list_append' before appending the namespace to list, check if the length is equal to SIZE_MAX. Set to 0 if true.
  • Introduce new option in get_public_key_request_options named 'should_auth': If should auth is set to true, the client performs a 'plookup' for the given key. Otherwise performs a 'lookup'.

- How to verify it

  • test for 'atcommons_enroll_namespace_list_from_string' on the way

- Description for the changelog

  • feat: impl to create new enollments using APKAM-OTP

srieteja and others added 30 commits November 13, 2024 17:57
@srieteja
feat: create atcommons and introduce enroll related deps
9295b4e
@srieteja
feat: introduce arg parser for at_activate
f786bc7
@XavierChanth @srieteja
feat: add apkam_symmetric_key to atkeys_file
c7c637d
@XavierChanth @srieteja
feat: add apkam_symmetric_key to atkeys
ff396f8
@srieteja
feat: introduce atactivate + hex, base64 and utf8 utils
8964e73
@srieteja
feat: cmakeLists update + default homedir impl + more atactivate code
6710bfb
@srieteja
docs: added docs + some more refactoring
c034d1e
@srieteja
fix: migration to mallocs + minor refactoring
b2925c7
@srieteja
chore: resolve compile warnings and refactor methods signatures
061439b
@srieteja
fix: import platform dependent header limits.
2e90e60
@srieteja
chore: rename all instance of "atclient_pkam_authenticate_options_*" …
04a872b 
…-> "atclient_authenticate_options_*"
@srieteja
fix: analyzer warnings
013fd0a
@srieteja
chore: update .gitignore
6957202
@srieteja
chore: fix method duplication
ecf30f1
@srieteja
chore: refactoring + add missing docs + better logging
9a59586
@srieteja
test: unit tests + refactoring
2491f69
@srieteja
test: unit tests + refactoring
eba4ff0
@srieteja
Merge remote-tracking branch 'origin/create_at_commons' into create_a…
e5153e9 
…t_commons

# Conflicts:
#	packages/atcommons/CMakeLists.txt
@srieteja
chore: address review comments
ac675cf
@srieteja
chore: address review comments - round 2
b23f45c
@srieteja
fix: atsign memory leak bug
c90f62b
@srieteja
fix: atsign memory leak bug
88501e5
@srieteja
Merge remote-tracking branch 'origin/create_at_commons' into create_a…
6a3231d 
…t_commons

# Conflicts:
#	packages/atauth/src/atactivate.c
@dependabot @srieteja
chore(deps): bump github/codeql-action in the github-actions group
6af0010 
Bumps the github-actions group with 1 update: [github/codeql-action](https://github.com/github/codeql-action).


Updates `github/codeql-action` from 3.27.1 to 3.27.3
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@4f3212b...396bb3e)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-actions
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @srieteja
chore(deps): bump github/codeql-action in the github-actions group
8e43d43 
Bumps the github-actions group with 1 update: [github/codeql-action](https://github.com/github/codeql-action).


Updates `github/codeql-action` from 3.27.3 to 3.27.4
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@396bb3e...ea9e4e3)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-actions
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @srieteja
chore(deps): bump github/codeql-action in the github-actions group
70ded5f 
Bumps the github-actions group with 1 update: [github/codeql-action](https://github.com/github/codeql-action).


Updates `github/codeql-action` from 3.27.4 to 3.27.5
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@ea9e4e3...f09c1c0)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-actions
...

Signed-off-by: dependabot[bot] <[email protected]>
@srieteja
feat: introduce new params into the arg_parser
a3d043a
@srieteja
feat: add param "err_msg" to atclient_pkam_authenticate
d646b46
@srieteja
feat: new method to parse enroll_namespace_list_t from string
aff312e
@srieteja
feat: introduce auth_cli
e8c7b71
@srieteja srieteja merged commit 0fcec5f into trunk Dec 19, 2024
8 checks passed
@srieteja srieteja deleted the enroll_using_otp branch December 19, 2024 18:26
JeremyTubongbanua pushed a commit that referenced this pull request Dec 20, 2024
@srieteja @XavierChanth
@dependabot @JeremyTubongbanua
feat: impl to create new enollments using APKAM-OTP (#453)
2bdc727 
* feat: introduce new params into the arg_parser

* feat: add param "err_msg" to atclient_pkam_authenticate

* feat: new method to parse enroll_namespace_list_t from string

* feat: introduce auth_cli

* chore: revert changes reg recursive write in atclient/connection.c

* feat: migrate constants to atauth_constants.h + minor refactoring

* feat: support for unauthenticated public key lookup

* feat: support to parse enroll namespaces from string

* feat: add new request param 'should_auth' in get_public_key_request_options

* feat: completed auth_cli implementation

* feat: impl multiple exits for auth_cli + minor refactoring

* fix: linux specific header issue + unit test

* chore: fix examples

* fix: introduce init method and use for enroll namespace list

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: xavierchanth <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
JeremyTubongbanua pushed a commit that referenced this pull request Dec 20, 2024
@srieteja @XavierChanth
@dependabot @JeremyTubongbanua
feat: impl to create new enollments using APKAM-OTP (#453)
5ce6435 
* feat: introduce new params into the arg_parser

* feat: add param "err_msg" to atclient_pkam_authenticate

* feat: new method to parse enroll_namespace_list_t from string

* feat: introduce auth_cli

* chore: revert changes reg recursive write in atclient/connection.c

* feat: migrate constants to atauth_constants.h + minor refactoring

* feat: support for unauthenticated public key lookup

* feat: support to parse enroll namespaces from string

* feat: add new request param 'should_auth' in get_public_key_request_options

* feat: completed auth_cli implementation

* feat: impl multiple exits for auth_cli + minor refactoring

* fix: linux specific header issue + unit test

* chore: fix examples

* fix: introduce init method and use for enroll namespace list

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: xavierchanth <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
JeremyTubongbanua pushed a commit that referenced this pull request Dec 20, 2024
@srieteja @XavierChanth
@dependabot @JeremyTubongbanua
feat: impl to create new enollments using APKAM-OTP (#453)
71a7865 
* feat: introduce new params into the arg_parser

* feat: add param "err_msg" to atclient_pkam_authenticate

* feat: new method to parse enroll_namespace_list_t from string

* feat: introduce auth_cli

* chore: revert changes reg recursive write in atclient/connection.c

* feat: migrate constants to atauth_constants.h + minor refactoring

* feat: support for unauthenticated public key lookup

* feat: support to parse enroll namespaces from string

* feat: add new request param 'should_auth' in get_public_key_request_options

* feat: completed auth_cli implementation

* feat: impl multiple exits for auth_cli + minor refactoring

* fix: linux specific header issue + unit test

* chore: fix examples

* fix: introduce init method and use for enroll namespace list

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: xavierchanth <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
JeremyTubongbanua pushed a commit that referenced this pull request Dec 23, 2024
@srieteja @XavierChanth
@dependabot @JeremyTubongbanua
feat: impl to create new enollments using APKAM-OTP (#453)
f83e784 
* feat: introduce new params into the arg_parser

* feat: add param "err_msg" to atclient_pkam_authenticate

* feat: new method to parse enroll_namespace_list_t from string

* feat: introduce auth_cli

* chore: revert changes reg recursive write in atclient/connection.c

* feat: migrate constants to atauth_constants.h + minor refactoring

* feat: support for unauthenticated public key lookup

* feat: support to parse enroll namespaces from string

* feat: add new request param 'should_auth' in get_public_key_request_options

* feat: completed auth_cli implementation

* feat: impl multiple exits for auth_cli + minor refactoring

* fix: linux specific header issue + unit test

* chore: fix examples

* fix: introduce init method and use for enroll namespace list

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: xavierchanth <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
JeremyTubongbanua pushed a commit that referenced this pull request Dec 23, 2024
@srieteja @XavierChanth
@dependabot @JeremyTubongbanua
feat: impl to create new enollments using APKAM-OTP (#453)
89da547 
* feat: introduce new params into the arg_parser

* feat: add param "err_msg" to atclient_pkam_authenticate

* feat: new method to parse enroll_namespace_list_t from string

* feat: introduce auth_cli

* chore: revert changes reg recursive write in atclient/connection.c

* feat: migrate constants to atauth_constants.h + minor refactoring

* feat: support for unauthenticated public key lookup

* feat: support to parse enroll namespaces from string

* feat: add new request param 'should_auth' in get_public_key_request_options

* feat: completed auth_cli implementation

* feat: impl multiple exits for auth_cli + minor refactoring

* fix: linux specific header issue + unit test

* chore: fix examples

* fix: introduce init method and use for enroll namespace list

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: xavierchanth <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
JeremyTubongbanua pushed a commit that referenced this pull request Dec 25, 2024
@srieteja @XavierChanth
@dependabot @JeremyTubongbanua
feat: impl to create new enollments using APKAM-OTP (#453)
7e73d9f 
* feat: introduce new params into the arg_parser

* feat: add param "err_msg" to atclient_pkam_authenticate

* feat: new method to parse enroll_namespace_list_t from string

* feat: introduce auth_cli

* chore: revert changes reg recursive write in atclient/connection.c

* feat: migrate constants to atauth_constants.h + minor refactoring

* feat: support for unauthenticated public key lookup

* feat: support to parse enroll namespaces from string

* feat: add new request param 'should_auth' in get_public_key_request_options

* feat: completed auth_cli implementation

* feat: impl multiple exits for auth_cli + minor refactoring

* fix: linux specific header issue + unit test

* chore: fix examples

* fix: introduce init method and use for enroll namespace list

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: xavierchanth <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
JeremyTubongbanua pushed a commit that referenced this pull request Dec 25, 2024
@srieteja @XavierChanth
@dependabot @JeremyTubongbanua
feat: impl to create new enollments using APKAM-OTP (#453)
f661887 
* feat: introduce new params into the arg_parser

* feat: add param "err_msg" to atclient_pkam_authenticate

* feat: new method to parse enroll_namespace_list_t from string

* feat: introduce auth_cli

* chore: revert changes reg recursive write in atclient/connection.c

* feat: migrate constants to atauth_constants.h + minor refactoring

* feat: support for unauthenticated public key lookup

* feat: support to parse enroll namespaces from string

* feat: add new request param 'should_auth' in get_public_key_request_options

* feat: completed auth_cli implementation

* feat: impl multiple exits for auth_cli + minor refactoring

* fix: linux specific header issue + unit test

* chore: fix examples

* fix: introduce init method and use for enroll namespace list

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: xavierchanth <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XavierChanth XavierChanth XavierChanth approved these changes

@JeremyTubongbanua JeremyTubongbanua Awaiting requested review from JeremyTubongbanua

@sitaram-kalluri sitaram-kalluri Awaiting requested review from sitaram-kalluri

@gkc gkc Awaiting requested review from gkc

@cpswan cpswan Awaiting requested review from cpswan

Assignees

@srieteja srieteja

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

at_activate: add functionality to create new enrollment using OTP
2 participants
@srieteja @XavierChanth