feat: Changes related to notify ephemeral #1544
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Before, when TTR was not set, received notifications only contained the key and not the associated value. When TTR is enabled, it includes the value and also stores the key in the receiver's secondary cache. There was no way to notify both the key and the value without caching the key in the receiver's secondary cache.
The revised implementation aims to notify both the key and its value without generating a cached copy in the receiver's secondary storage.
- How I did it
resource_manager.dart
-> "prepareNotifyCommandBody" method, the notify command is prepared to send notification to the receiver's secondary. The value is included to the commandBody only IF the TTR is NOT NULL.- How to verify it
Tested the changes manually and value is received without a cached copy getting created on the receiver's end.
- Description for the changelog