Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Changes related to notify ephemeral #1544

Merged
merged 6 commits into from
Sep 12, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/at_secondary_server/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
## 3.0.36
- fix: Implement notify ephemeral changes - Send notification with value without caching the key on receiver's secondary server
## 3.0.35
- chore: Upgraded at_persistence_secondary_server to 3.0.57 for memory optimization in commit log
- feat: APKAM keys verb implementation
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ class ResourceManager {
NotifyConnectionsPool.getInstance();

int get outboundConnectionLimit => _notifyConnectionsPool.size;

set outboundConnectionLimit(int ocl) => _notifyConnectionsPool.size = ocl;

void start() {
Expand Down Expand Up @@ -201,6 +202,9 @@ class ResourceManager {
// looked at this code.
String commandBody;
commandBody = '${atNotification.notification}';
if (atNotification.atValue != null) {
commandBody = '$commandBody:${atNotification.atValue}';
}
var atMetaData = atNotification.atMetadata;
if (atMetaData != null) {
if (atNotification.atMetadata!.skeEncAlgo != null) {
Expand Down Expand Up @@ -237,7 +241,7 @@ class ResourceManager {
}
if (atMetaData.ttr != null) {
commandBody =
'ttr:${atMetaData.ttr}:ccd:${atMetaData.isCascade}:$commandBody:${atNotification.atValue}';
'ttr:${atMetaData.ttr}:ccd:${atMetaData.isCascade}:$commandBody';
}
if (atMetaData.ttb != null) {
commandBody = 'ttb:${atMetaData.ttb}:$commandBody';
Expand Down
2 changes: 1 addition & 1 deletion packages/at_secondary_server/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: at_secondary
description: Implementation of secondary server.
version: 3.0.35
version: 3.0.36
repository: https://github.com/atsign-foundation/at_server
homepage: https://www.example.com
publish_to: none
Expand Down
Loading