Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Sync skip deletes until #2131

Merged
merged 23 commits into from
Dec 4, 2024
Merged

feat: Sync skip deletes until #2131

merged 23 commits into from
Dec 4, 2024

Conversation

murali-shris
Copy link
Member

@murali-shris murali-shris commented Oct 17, 2024 •
edited
Loading

- What I did

  • added ability to skip delete commit entries in sync response. If skipDeletes flag is set to true, delete commits will not be returned in sync response from server to client.
    - How I did it
  • introduced skipDeletes flag in sync:from syntax
  • added optional flag skipDeletes=false in commitLog getEntries. If set to true, delete commits will be skipped. if not passed, then existing behaviour applies. Refactored the code to introduce a strategy pattern to fetch keys.
  • added unit tests
    - How to verify it
  • tests should pass

persistence change in this PR:
#2166

@murali-shris murali-shris requested a review from VJag October 17, 2024 09:54
@murali-shris murali-shris changed the title feat: Sync skip deletes feat: Sync skip deletes <do not merge> Oct 17, 2024
@murali-shris murali-shris marked this pull request as ready for review October 22, 2024 07:06
gkc
gkc requested changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@gkc gkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but have suggested adding couple more tests

@murali-shris murali-shris requested review from VJag and gkc November 7, 2024 16:29
@murali-shris murali-shris mentioned this pull request Nov 11, 2024
Closed
@murali-shris murali-shris mentioned this pull request Dec 3, 2024
Merged
@murali-shris murali-shris changed the title feat: Sync skip deletes <do not merge> feat: Sync skip deletes until Dec 4, 2024
@murali-shris
Copy link
Member Author

@gkc I have published persistence secondary and this PR is ready to be merged

@murali-shris murali-shris merged commit 480901b into trunk Dec 4, 2024
26 checks passed
@murali-shris murali-shris deleted the sync_skip_deletes branch December 4, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkc gkc gkc approved these changes

@sitaram-kalluri sitaram-kalluri sitaram-kalluri approved these changes

@VJag VJag Awaiting requested review from VJag

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@murali-shris @gkc @sitaram-kalluri @VJag