Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Sync skip deletes until #2131

Merged
merged 23 commits into from
Dec 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
e577b31
feat:skipDeletes server changes
murali-shris Oct 8, 2024
2187883
Merge branch 'trunk' of https://github.com/atsign-foundation/at_serve…
murali-shris Oct 17, 2024
1a05096
fix: pubspec add at_commons dependency overrides
murali-shris Oct 17, 2024
5714380
fix: replace skipDeletes check with strategy pattern
murali-shris Oct 17, 2024
e9a6356
fix: added dart docs
murali-shris Oct 22, 2024
6d706a7
Merge branch 'trunk' into sync_skip_deletes
murali-shris Oct 22, 2024
0c53be2
fix: skip delete until server changes and unit tests
murali-shris Nov 5, 2024
832f142
feat: add skip delete unit test
murali-shris Nov 5, 2024
b5bac00
Merge branch 'sync_skip_deletes' of https://github.com/atsign-foundat…
murali-shris Nov 5, 2024
38b11da
fix: added regex scenario in sync unit test
murali-shris Nov 5, 2024
e949f00
feat: added unit tests in sync for skip deletes
murali-shris Nov 7, 2024
2b9285b
fix: rename skipDeletes to skipDeletes until
murali-shris Nov 7, 2024
8e3f568
Merge branch 'trunk' into sync_skip_deletes
murali-shris Nov 7, 2024
d43b569
feat: added unit test for last delete commit not matching regex
murali-shris Nov 20, 2024
d503fca
Merge branch 'sync_skip_deletes' of https://github.com/atsign-foundat…
murali-shris Nov 20, 2024
2050b7c
Merge branch 'trunk' of https://github.com/atsign-foundation/at_serve…
murali-shris Dec 3, 2024
3808ed9
fix: pubspec changes
murali-shris Dec 3, 2024
6ffa95b
fix: analyzer issue
murali-shris Dec 3, 2024
bc95f61
fix: pubspec persistence dependency overrides change to trunk
murali-shris Dec 3, 2024
281c375
fix: at_commons dependency to 5.1.0
murali-shris Dec 3, 2024
10acc4d
fix: revert unwanted change in commit log keystore
murali-shris Dec 3, 2024
aa5e6d4
fix: changelog and pubspec for server release
murali-shris Dec 4, 2024
c6a3229
Merge branch 'trunk' into sync_skip_deletes
murali-shris Dec 4, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/at_secondary_server/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
# 3.1.0
- feat: sync skip deletes until changes
- build[deps]: Upgraded the following package:
- at_commons to v5.1.0
- at_persistence_secondary_server to v3.1.0
# 3.0.52
- build[deps]: Upgraded the following package:
- at_commons to v5.0.2
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,14 @@ class SyncProgressiveVerbHandler extends AbstractVerbHandler {
// Get Commit Log Instance.
var atCommitLog = await (AtCommitLogManagerImpl.getInstance()
.getCommitLog(AtSecondaryServerImpl.getInstance().currentAtSign));
int? skipDeletesUntil = verbParams['skipDeletesUntil'] != null
? int.parse(verbParams['skipDeletesUntil']!)
: null;
// Get entries to sync
var commitEntryIterator = atCommitLog!.getEntries(
int.parse(verbParams[AtConstants.fromCommitSequence]!) + 1,
regex: verbParams['regex']);
regex: verbParams['regex'],
skipDeletesUntil: skipDeletesUntil);

List<KeyStoreEntry> syncResponse = [];
await prepareResponse(capacity, syncResponse, commitEntryIterator,
Expand All @@ -69,7 +73,6 @@ class SyncProgressiveVerbHandler extends AbstractVerbHandler {
.get(enrollmentId))
.namespaces;
}

while (commitEntryIterator.moveNext() &&
syncResponse.length < AtSecondaryConfig.syncPageLimit) {
var atKeyType = AtKey.getKeyType(commitEntryIterator.current.key,
Expand Down
6 changes: 3 additions & 3 deletions packages/at_secondary_server/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: at_secondary
description: Implementation of secondary server.
version: 3.0.52
version: 3.1.0
repository: https://github.com/atsign-foundation/at_server
homepage: https://www.example.com
publish_to: none
Expand All @@ -19,13 +19,13 @@ dependencies:
basic_utils: 5.7.0
ecdsa: 0.1.0
encrypt: 5.0.3
at_commons: 5.0.2
at_commons: 5.1.0
at_utils: 3.0.19
at_chops: 2.2.0
at_lookup: 3.0.49
at_server_spec: 5.0.2
at_persistence_spec: 2.0.14
at_persistence_secondary_server: 3.0.66
at_persistence_secondary_server: 3.1.0
intl: ^0.19.0
json_annotation: ^4.8.0
version: 3.0.2
Expand Down
Loading
Loading