Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: require flake<5.0.0 #47

Closed
wants to merge 3 commits into from
Closed

TST: require flake<5.0.0 #47

wants to merge 3 commits into from

Conversation

hagenw
Copy link
Member

@hagenw hagenw commented Jan 2, 2023

To avoid an error with pytest-flake8 (tholo/pytest-flake8#87), this requires flake<5.0.0

@hagenw hagenw mentioned this pull request Jan 2, 2023
Closed
@hagenw
Copy link
Member Author

hagenw commented Jan 2, 2023

It seems older versions of flake8 are also no longer compatible with new version of importlib-metadata see https://stackoverflow.com/a/73932581. My guess is that is the reason why the test is failing here.

So maybe it is time we look for a proper alternative to use pytest-flake8.

@hagenw hagenw mentioned this pull request Jan 2, 2023
Merged
@hagenw
Copy link
Member Author

hagenw commented Jan 2, 2023

Closing in favor of #49

@hagenw hagenw closed this Jan 2, 2023
@hagenw hagenw deleted the flake8 branch January 3, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hagenw