Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: use pre-commit for flake8 checks #49

Merged
merged 20 commits into from
Jan 3, 2023
Merged

TST: use pre-commit for flake8 checks #49

merged 20 commits into from
Jan 3, 2023

Conversation

hagenw
Copy link
Member

@hagenw hagenw commented Jan 2, 2023 •
edited
Loading

Alternative to #47

This uses pre-commit instead of pytest to execute the flake8 tests.

It also fixes a few flake8 issues and adds a coding convention section to CONTRIBUTING.

@hagenw hagenw changed the title TST: use pre-commit for flake8 checks WIP: TST: use pre-commit for flake8 checks Jan 2, 2023
@hagenw
Copy link
Member Author

hagenw commented Jan 2, 2023

As expected when we have a flake8 error (here whitespace) we get a failing pipeline:

image

@hagenw hagenw mentioned this pull request Jan 2, 2023
Closed
@codecov
Copy link

codecov bot commented Jan 2, 2023 •
edited
Loading

Codecov Report

Merging #49 (c5d5d1c) into master (775c6ba) will not change coverage.
The diff coverage is 100.0%.

Impacted Files Coverage Δ
audonnx/core/testing.py 100.0% <100.0%> (ø)

@hagenw hagenw changed the title WIP: TST: use pre-commit for flake8 checks TST: use pre-commit for flake8 checks Jan 3, 2023
@hagenw hagenw merged commit 931cb7a into master Jan 3, 2023
@hagenw hagenw deleted the pre-commit branch January 3, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hagenw