Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chardev: add case for chardev with log file #4966

Merged
merged 1 commit into from
Jul 12, 2023
Merged

chardev: add case for chardev with log file #4966

merged 1 commit into from
Jul 12, 2023

Conversation

nanli1
Copy link
Contributor

@nanli1 nanli1 commented Jun 15, 2023 •
edited
Loading

VIRT-296959:chardev with log file
Signed-off-by: nanli [email protected]


 avocado run --vt-type libvirt --test-runner=runner --vt-machine-type q35 chardev.log

 (1/2) type_specific.io-github-autotest-libvirt.chardev.log.console.pty: PASS (52.07 s)
 (2/2) type_specific.io-github-autotest-libvirt.chardev.log.console.unix: PASS (52.49 s)

Depend on avocado-framework/avocado-vt#3717

@nanli1 nanli1 changed the title add case for chardev with log file chardev: add case for chardev with log file Jun 21, 2023
cliping
cliping approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@cliping cliping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Yingshun
Yingshun reviewed Jul 4, 2023
View reviewed changes
libvirt/tests/cfg/chardev/log/chardev_with_log_file.cfg Outdated
Comment on lines 4 to 5
login_user = "root"
login_passwd = "redhat"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please use 'username/password' in guest-os/Linux.cfg? We should avoid plain text authentication in code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks yingshun, Done :D

@nanli1 nanli1 force-pushed the add_case_for_chardev_with_log_file branch from 1efb3fa to 1d62e95 Compare July 10, 2023 10:47
@nanli1 nanli1 mentioned this pull request Jul 12, 2023
Merged
@nanli1
add case for chardev with log file
5b0e83d 
  VIRT-296959:chardev with log file
Signed-off-by: nanli <[email protected]>
@nanli1 nanli1 force-pushed the add_case_for_chardev_with_log_file branch from 1d62e95 to 5b0e83d Compare July 12, 2023 04:26
@nanli1 nanli1 requested a review from Yingshun July 12, 2023 04:28
@Yingshun Yingshun merged commit f0cc737 into autotest:master Jul 12, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cliping cliping cliping approved these changes

@Yingshun Yingshun Yingshun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nanli1 @cliping @Yingshun