add log_file to console xml #3717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dzhengfy Hi Dzheng ,Could you help review |
dzhengfy
reviewed
Jul 25, 2023
| @@ -26,6 +26,8 @@ def __init__(self, type_name='pty', virsh_instance=base.virsh): | |||
| has_subclass=True) | |||
| accessors.XMLElementDict('alias', self, parent_xpath='/', | |||
| tag_name='alias') | |||
| accessors.XMLElementDict('log_file', self, parent_xpath='/', | |||
There was a problem hiding this comment.
According to the log definition in libvirt.org, I think it is better to use log instead of log_file, because it also include other attributes, like append. What do you think?
<log file="/var/log/libvirt/qemu/guestname-serial0.log" append="off"/>
There was a problem hiding this comment.
Hi dzheng, Thanks your reminder ,Done
log tag needs to be added Signed-off-by: nanli <[email protected]>
nanli1
force-pushed
the
add_element_for_console
branch
from
ef8596f
to
e0cec25
Compare
dzhengfy
approved these changes
Jul 26, 2023
|
@nanli1 tp-libvirt seems need update accordingly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
log_file needs to be added
Signed-off-by: nanli [email protected]
for autotest/tp-libvirt#4966