-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(avoidance): expand detection area to prevent chattering #5267
Merged
satoshi-ota
merged 2 commits into
autowarefoundation:main
from
satoshi-ota:fix/avoidance-request-chattering-2
Oct 12, 2023
Merged
fix(avoidance): expand detection area to prevent chattering #5267
satoshi-ota
merged 2 commits into
autowarefoundation:main
from
satoshi-ota:fix/avoidance-request-chattering-2
Oct 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: satoshi-ota <[email protected]>
satoshi-ota
requested review from
rej55,
kosuke55,
kyoichi-sugahara,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
tkimura4,
purewater0901 and
zulfaqar-azmi-t4
as code owners
October 11, 2023 06:14
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
Oct 11, 2023
satoshi-ota
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Oct 11, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5267 +/- ##
==========================================
- Coverage 14.84% 14.79% -0.06%
==========================================
Files 1649 1646 -3
Lines 114166 114053 -113
Branches 35323 35221 -102
==========================================
- Hits 16943 16869 -74
- Misses 78102 78187 +85
+ Partials 19121 18997 -124
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
takayuki5168
approved these changes
Oct 12, 2023
satoshi-ota
added a commit
to tier4/autoware.universe
that referenced
this pull request
Oct 12, 2023
…foundation#5267) Signed-off-by: satoshi-ota <[email protected]>
Merged
4 tasks
satoshi-ota
added a commit
to satoshi-ota/autoware.universe
that referenced
this pull request
Oct 13, 2023
…foundation#5267) Signed-off-by: satoshi-ota <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🤖 Generated by Copilot at 5d511c7
Improved the object avoidance logic in the behavior path planner by adding a flag to indicate the module status and expanding the detection area width accordingly. Modified the
separateObjectsByPath
function inutils.hpp
andutils.cpp
to accept and use the flag.Tests performed
Effects on system behavior
Nothing.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.