Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(avoidance): expand detection area to prevent chattering #5267

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Oct 11, 2023

Description

🤖 Generated by Copilot at 5d511c7

Improved the object avoidance logic in the behavior path planner by adding a flag to indicate the module status and expanding the detection area width accordingly. Modified the separateObjectsByPath function in utils.hpp and utils.cpp to accept and use the flag.

Tests performed

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Oct 11, 2023
@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Attention: 90 lines in your changes are missing coverage. Please review.

Comparison is base (84995ec) 14.84% compared to head (8bff07b) 14.79%.
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5267      +/-   ##
==========================================
- Coverage   14.84%   14.79%   -0.06%     
==========================================
  Files        1649     1646       -3     
  Lines      114166   114053     -113     
  Branches    35323    35221     -102     
==========================================
- Hits        16943    16869      -74     
- Misses      78102    78187      +85     
+ Partials    19121    18997     -124     
Flag Coverage Δ *Carryforward flag
differential 12.37% <0.00%> (?)
total 14.80% <ø> (-0.04%) ⬇️ Carriedforward from 5d511c7

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...r_path_planner/scene_module/lane_change/normal.hpp 0.00% <ø> (ø)
...ity_smoother/src/motion_velocity_smoother_node.cpp 28.28% <ø> (+0.05%) ⬆️
...lude/obstacle_avoidance_planner/common_structs.hpp 55.88% <ø> (-1.27%) ⬇️
...lanner/include/obstacle_avoidance_planner/node.hpp 60.00% <ø> (ø)
planning/obstacle_avoidance_planner/src/node.cpp 39.11% <ø> (+0.26%) ⬆️
...top_planner/include/obstacle_stop_planner/node.hpp 0.00% <ø> (ø)
planning/obstacle_stop_planner/src/node.cpp 9.33% <ø> (ø)
..._smoother/include/path_smoother/common_structs.hpp 41.17% <ø> (-1.69%) ⬇️
...er/include/path_smoother/elastic_band_smoother.hpp 60.00% <ø> (ø)
...anning/path_smoother/src/elastic_band_smoother.cpp 30.51% <ø> (+0.39%) ⬆️
... and 4 more

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@satoshi-ota satoshi-ota enabled auto-merge (squash) October 12, 2023 04:09
@satoshi-ota satoshi-ota merged commit a220a96 into autowarefoundation:main Oct 12, 2023
22 of 27 checks passed
@satoshi-ota satoshi-ota deleted the fix/avoidance-request-chattering-2 branch October 12, 2023 05:03
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Oct 12, 2023
satoshi-ota added a commit to satoshi-ota/autoware.universe that referenced this pull request Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants