Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(intersection): not detect stuck vehicle when turning left #5268

Merged

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Oct 11, 2023

Description

No stuck detection when the ego turns left

before
Unnecessary stop line is inserted.
image

after
image

Tests performed

psim

Effects on system behavior

No stuck detection when turning left

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Oct 11, 2023
@takayuki5168 takayuki5168 marked this pull request as ready for review October 11, 2023 06:54
@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 11, 2023
Copy link
Contributor

@soblin soblin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: set a parameter for this PR later

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (2aa9d1c) 14.79% compared to head (d4995a0) 14.79%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5268      +/-   ##
==========================================
- Coverage   14.79%   14.79%   -0.01%     
==========================================
  Files        1646     1646              
  Lines      114015   114016       +1     
  Branches    35203    35204       +1     
==========================================
  Hits        16871    16871              
- Misses      78146    78147       +1     
  Partials    18998    18998              
Flag Coverage Δ *Carryforward flag
differential 6.29% <0.00%> (?)
total 14.79% <ø> (ø) Carriedforward from 2aa9d1c

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...ity_intersection_module/src/scene_intersection.cpp 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin soblin merged commit 84995ec into autowarefoundation:main Oct 11, 2023
37 of 40 checks passed
@soblin soblin deleted the feat/no-stuck-when-turning-left branch October 11, 2023 09:37
@soblin soblin restored the feat/no-stuck-when-turning-left branch October 11, 2023 09:37
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Oct 12, 2023
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Oct 12, 2023
@rej55 rej55 deleted the feat/no-stuck-when-turning-left branch December 25, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants