Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(goal_planner): disable freespace pull over after arriving modified goal #5290

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Oct 12, 2023

Description

no need to execute freespace pull over after arriving modified goal

Related links

Tests performed

evaluator_description: fix/disable_freespace_on_modified_goal
2023/10/12 https://evaluation.tier4.jp/evaluation/reports/9712fece-0731-5d14-8907-a7935e35a6c4/?project_id=prd_jt

Notes for reviewers

Interface changes

none

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Oct 12, 2023
@kosuke55 kosuke55 added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Oct 12, 2023
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Oct 12, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Attention: 41 lines in your changes are missing coverage. Please review.

Comparison is base (02eb843) 14.83% compared to head (d2cd913) 14.86%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5290      +/-   ##
==========================================
+ Coverage   14.83%   14.86%   +0.03%     
==========================================
  Files        1649     1649              
  Lines      114278   114309      +31     
  Branches    35384    35405      +21     
==========================================
+ Hits        16956    16996      +40     
+ Misses      78176    78141      -35     
- Partials    19146    19172      +26     
Flag Coverage Δ *Carryforward flag
differential 12.56% <22.64%> (?)
total 14.84% <ø> (+<0.01%) ⬆️ Carriedforward from 02eb843

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...em_rviz_plugin/src/mrm_summary_overlay_display.cpp 0.00% <ø> (ø)
...lanner/scene_module/avoidance/avoidance_module.hpp 7.81% <ø> (ø)
..._planner/utils/avoidance/avoidance_module_data.hpp 0.00% <ø> (ø)
...behavior_velocity_intersection_module/src/util.cpp 0.00% <ø> (ø)
...th_planner/src/scene_module/lane_change/normal.cpp 4.09% <0.00%> (-0.01%) ⬇️
...ath_planner/src/scene_module/avoidance/manager.cpp 5.94% <0.00%> (-0.05%) ⬇️
.../scene_module/goal_planner/goal_planner_module.cpp 5.60% <0.00%> (-0.03%) ⬇️
planning/behavior_path_planner/src/utils/utils.cpp 13.56% <0.00%> (-0.03%) ⬇️
...er/src/scene_module/avoidance/avoidance_module.cpp 12.85% <26.66%> (+0.63%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@kosuke55 kosuke55 merged commit d8f285b into main Oct 12, 2023
@kosuke55 kosuke55 deleted the fix/disable_freespace_on_modified_goal branch October 12, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants