Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): fix calcMinimumLongitudinalLength args #5299

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Oct 13, 2023

Description

fix calcMinimumLongitudinalLength args

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 13, 2023
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Oct 13, 2023
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (e566988) 14.80% compared to head (daeff82) 14.79%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5299      +/-   ##
==========================================
- Coverage   14.80%   14.79%   -0.01%     
==========================================
  Files        1659     1659              
  Lines      114868   114872       +4     
  Branches    35406    35411       +5     
==========================================
  Hits        17001    17001              
- Misses      78680    78684       +4     
  Partials    19187    19187              
Flag Coverage Δ *Carryforward flag
differential 12.56% <0.00%> (?)
total 14.80% <ø> (+<0.01%) ⬆️ Carriedforward from e566988

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...ion/ndt_scan_matcher/src/ndt_scan_matcher_core.cpp 0.00% <ø> (ø)
...ing/behavior_path_planner/src/utils/path_utils.cpp 13.99% <0.00%> (ø)
...th_planner/src/scene_module/lane_change/normal.cpp 4.09% <0.00%> (-0.01%) ⬇️
...avior_path_planner/src/utils/lane_change/utils.cpp 0.43% <0.00%> (-0.01%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kosuke55 kosuke55 merged commit 910f30b into main Oct 13, 2023
@kosuke55 kosuke55 deleted the fix/calcMinimumLongitudinalLength branch October 13, 2023 06:43
rej55 pushed a commit to tier4/autoware.universe that referenced this pull request Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants