fix(ndt_scan_matcher): fix validate_num_iteration

[SakodaShintaro]

Description

Corrected the argument given to validate_num_iteration.

See tier4/ndt_omp#23

Tests performed

It has been confirmed that this can be done with logging_simulator.

Also, I degraded the accuracy of the localization and set NDT to run at its maximum iterations, then ran Autoware.

The following display was successfully obtained.

1697696962.0746102 [ndt_scan_matcher-32] �[33m[WARN 1697696962.055757336] [localization.pose_estimator.ndt_scan_matcher]: The number of iterations has reached its upper limit. The number of iterations: 30, Limit: 30 (validate_num_iteration() at /home/shintarosakoda/autoware/src/universe/autoware.universe/localization/ndt_scan_matcher/src/ndt_scan_matcher_core.cpp:655)�[0m

Effects on system behavior

The detection of when iteration_num reaches its maximum value will work correctly.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

[codecov]

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (b019643) 14.77% compared to head (d9e423f) 14.77%.
Report is 4 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5354   +/-   ##
=======================================
  Coverage   14.77%   14.77%           
=======================================
  Files        1662     1662           
  Lines      115382   115378    -4     
  Branches    35610    35610           
=======================================
  Hits        17045    17045           
+ Misses      79115    79111    -4     
  Partials    19222    19222           

Flag	Coverage Δ		*Carryforward flag
differential	7.12% <0.00%> (?)
total	14.77% <ø> (+<0.01%)	⬆️	Carriedforward from b019643

*This pull request uses carry forward flags. Click here to find out more.

Files	Coverage Δ
...anner/include/behavior_path_planner/parameters.hpp	57.14% <ø> (ø)
.../include/behavior_path_planner/planner_manager.hpp	19.54% <ø> (ø)
...ule/dynamic_avoidance/dynamic_avoidance_module.hpp	0.00% <ø> (ø)
.../scene_module/goal_planner/goal_planner_module.hpp	24.56% <ø> (ø)
...th_planner/scene_module/scene_module_interface.hpp	11.11% <ø> (ø)
..._planner/utils/avoidance/avoidance_module_data.hpp	0.00% <ø> (ø)
...anner/utils/drivable_area_expansion/parameters.hpp	12.12% <ø> (ø)
.../utils/drivable_area_expansion/path_projection.hpp	84.21% <ø> (ø)
...ic_parallel_parking/geometric_parallel_parking.hpp	16.66% <ø> (ø)
.../utils/goal_planner/default_fixed_goal_planner.hpp	100.00% <ø> (ø)
... and 39 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.